fix(logs): route daemon + CLI log reads through sanitized filename helper

Addresses Codex review on PR #604: the writer sanitized per-server log
filenames but two READ sites still derived the raw server-%s.log path,
so GET /api/v1/servers/{id}/logs and no-daemon CLI reads still 404'd for
namespace/name registry servers. Export ServerLogFilename and route both
read sites through it; tie the read-path filename to the writer's flat
file in the regression test.

Related #598

Author: Dumbris

cmd/mcpproxy/upstream_cmd.go

@@ -772,7 +772,7 @@ func runUpstreamLogsFromFile(globalConfig *config.Config, serverName string) err
 		}
 	}
 
-	logFile := filepath.Join(logDir, fmt.Sprintf("server-%s.log", serverName))
+	logFile := filepath.Join(logDir, logs.ServerLogFilename(serverName))
 
 	// Check if file exists
 	if _, err := os.Stat(logFile); os.IsNotExist(err) {

internal/logs/logger.go

@@ -280,6 +280,16 @@ func serverLogFilename(serverName string) string {
 	return fmt.Sprintf("server-%s.log", sanitizeServerLogName(serverName))
 }
 
+// ServerLogFilename is the exported accessor for the per-server log filename.
+// Read sites outside this package (the REST/daemon log reader in internal/server
+// and the no-daemon CLI file reader in cmd/mcpproxy) MUST derive the path through
+// this helper so reads resolve to the same sanitized flat file the writers create
+// for namespace/name registry servers (MCP-1111). Do not re-derive "server-%s.log"
+// by hand at a call site.
+func ServerLogFilename(serverName string) string {
+	return serverLogFilename(serverName)
+}
+
 // sanitizeServerLogName replaces every character that is not safe in a single
 // filename element with "_", keeping ASCII letters, digits, ".", "-" and "_".
 // The result is always a single path element (no "/" or "\\"), so it can never

internal/logs/logger_test.go

@@ -77,4 +77,11 @@ func TestCreateUpstreamServerLogger_NamespacedNameFlatFile(t *testing.T) {
 	require.NoError(t, err)
 	require.NotEmpty(t, lines, "tail reader must round-trip the namespaced server name to its flat log file")
 	assert.Contains(t, lines[len(lines)-1], "hello from polymarket-guard")
+
+	// The exported helper (used by the out-of-package read sites in internal/server
+	// and cmd/mcpproxy) MUST resolve a namespaced name to the same flat file the
+	// writer created — otherwise daemon/CLI log reads 404 for slash-bearing names
+	// (the read-site divergence Codex flagged on PR #604).
+	assert.Equal(t, flatPath, filepath.Join(logDir, ServerLogFilename(serverName)),
+		"ServerLogFilename must resolve to the writer's flat file for a namespaced name")
 }

internal/server/server.go

@@ -2282,7 +2282,7 @@ func (s *Server) GetServerLogs(serverName string, tail int) ([]contracts.LogEntr
 		}
 	}
 
-	logFile := filepath.Join(logDir, fmt.Sprintf("server-%s.log", serverName))
+	logFile := filepath.Join(logDir, logs.ServerLogFilename(serverName))
 
 	// Check if file exists
 	if _, err := os.Stat(logFile); os.IsNotExist(err) {