Refactor autostart checks and improve menu item updates

- Replaced string literals for OS checks with constants for better readability and maintainability.
- Updated file permissions for plist file writing to enhance security.
- Simplified menu item update logic in MenuManager to reduce nesting and improve clarity.

Author: Dumbris

internal/tray/autostart.go

@@ -74,7 +74,7 @@ func NewAutostartManager() (*AutostartManager, error) {
 
 // IsEnabled checks if autostart is currently enabled
 func (m *AutostartManager) IsEnabled() bool {
-	if runtime.GOOS != "darwin" {
+	if runtime.GOOS != osDarwin {
 		return false
 	}
 
@@ -90,7 +90,7 @@ func (m *AutostartManager) IsEnabled() bool {
 
 // Enable enables autostart functionality
 func (m *AutostartManager) Enable() error {
-	if runtime.GOOS != "darwin" {
+	if runtime.GOOS != osDarwin {
 		return fmt.Errorf("autostart is only supported on macOS")
 	}
 
@@ -119,7 +119,7 @@ func (m *AutostartManager) Enable() error {
 
 	// Write plist file
 	plistPath := filepath.Join(launchAgentsDir, "com.smartmcpproxy.mcpproxy.plist")
-	if err := os.WriteFile(plistPath, []byte(plistContent), 0644); err != nil {
+	if err := os.WriteFile(plistPath, []byte(plistContent), 0600); err != nil {
 		return fmt.Errorf("failed to write plist file: %w", err)
 	}
 
@@ -137,7 +137,7 @@ func (m *AutostartManager) Enable() error {
 
 // Disable disables autostart functionality
 func (m *AutostartManager) Disable() error {
-	if runtime.GOOS != "darwin" {
+	if runtime.GOOS != osDarwin {
 		return fmt.Errorf("autostart is only supported on macOS")
 	}
 

internal/tray/managers.go

@@ -330,15 +330,18 @@ func (m *MenuManager) UpdateUpstreamServersMenu(servers []map[string]interface{}
 	} else {
 		// No new servers - just update existing items
 		for _, serverName := range currentServerNames {
-			if menuItem, exists := m.serverMenuItems[serverName]; exists {
-				serverData := currentServerMap[serverName]
-				// Server exists, update its display and ensure it's visible
-				status, tooltip := m.getServerStatusDisplay(serverData)
-				menuItem.SetTitle(status)
-				menuItem.SetTooltip(tooltip)
-				m.updateServerActionMenus(serverName, serverData) // Update sub-menu items too
-				menuItem.Show()
+			menuItem, exists := m.serverMenuItems[serverName]
+			if !exists {
+				continue
 			}
+			
+			serverData := currentServerMap[serverName]
+			// Server exists, update its display and ensure it's visible
+			status, tooltip := m.getServerStatusDisplay(serverData)
+			menuItem.SetTitle(status)
+			menuItem.SetTooltip(tooltip)
+			m.updateServerActionMenus(serverName, serverData) // Update sub-menu items too
+			menuItem.Show()
 		}
 
 		// Hide servers that are no longer in the config

internal/tray/tray.go

@@ -29,8 +29,17 @@ import (
 )
 
 const (
-	repo     = "smart-mcp-proxy/mcpproxy-go" // Actual repository
-	osDarwin = "darwin"
+	repo        = "smart-mcp-proxy/mcpproxy-go"
+	checkPeriod = 1 * time.Hour
+
+	// OS constants
+	osWindows = "windows"
+	osDarwin  = "darwin"
+	osLinux   = "linux"
+
+	// String constants
+	strTrue    = "true"
+	strUnknown = "unknown"
 )
 
 //go:embed icon-mono-44.png
@@ -503,7 +512,7 @@ func (a *App) updateStatusFromData(statusData interface{}) {
 			// DON'T clear quarantine menu - quarantine data is persistent storage,
 			// not runtime connection data. Users should manage quarantined servers
 			// even when server is stopped.
-			//a.menuManager.UpdateQuarantineMenu([]map[string]interface{}{})
+			// a.menuManager.UpdateQuarantineMenu([]map[string]interface{}{})
 		}
 	}
 }
@@ -695,19 +704,19 @@ func (a *App) onExit() {
 // checkForUpdates checks for new releases on GitHub
 func (a *App) checkForUpdates() {
 	// Check if auto-update is disabled by environment variable
-	if os.Getenv("MCPPROXY_DISABLE_AUTO_UPDATE") == "true" {
+	if os.Getenv("MCPPROXY_DISABLE_AUTO_UPDATE") == strTrue {
 		a.logger.Info("Auto-update disabled by environment variable")
 		return
 	}
 
 	// Disable auto-update for app bundles by default (DMG installation should be manual)
-	if a.isAppBundle() && os.Getenv("MCPPROXY_UPDATE_APP_BUNDLE") != "true" {
+	if a.isAppBundle() && os.Getenv("MCPPROXY_UPDATE_APP_BUNDLE") != strTrue {
 		a.logger.Info("Auto-update disabled for app bundle installations (use DMG for updates)")
 		return
 	}
 
 	// Check if notification-only mode is enabled
-	notifyOnly := os.Getenv("MCPPROXY_UPDATE_NOTIFY_ONLY") == "true"
+	notifyOnly := os.Getenv("MCPPROXY_UPDATE_NOTIFY_ONLY") == strTrue
 
 	a.statusItem.SetTitle("Checking for updates...")
 	defer a.updateStatus() // Restore original status after check
@@ -772,7 +781,7 @@ func (a *App) findAssetURL(release *GitHubRelease) (string, error) {
 	// Determine file extension based on platform
 	var extension string
 	switch runtime.GOOS {
-	case "windows":
+	case osWindows:
 		extension = ".zip"
 	default: // macOS, Linux
 		extension = ".tar.gz"
@@ -813,7 +822,7 @@ func (a *App) isHomebrewInstallation() bool {
 
 // isAppBundle checks if running from macOS app bundle
 func (a *App) isAppBundle() bool {
-	if runtime.GOOS != "darwin" {
+	if runtime.GOOS != osDarwin {
 		return false
 	}
 
@@ -900,7 +909,9 @@ func (a *App) applyTarGzUpdate(body io.Reader) error {
 	}
 
 	// Open the tar.gz file and extract the binary
-	tmpfile.Seek(0, 0)
+	if _, err := tmpfile.Seek(0, 0); err != nil {
+		return fmt.Errorf("failed to seek to beginning of file: %w", err)
+	}
 
 	gzr, err := gzip.NewReader(tmpfile)
 	if err != nil {
@@ -963,11 +974,11 @@ func (a *App) openLogsDir() {
 func (a *App) openDirectory(dirPath, dirType string) {
 	var cmd *exec.Cmd
 	switch runtime.GOOS {
-	case "darwin":
+	case osDarwin:
 		cmd = exec.Command("open", dirPath)
-	case "linux":
+	case osLinux:
 		cmd = exec.Command("xdg-open", dirPath)
-	case "windows":
+	case osWindows:
 		cmd = exec.Command("explorer", dirPath)
 	default:
 		a.logger.Warn("Unsupported OS for opening directory", zap.String("os", runtime.GOOS))