Skip to content

Commit 9c3e554

Browse files
committed
fix: clean up tool approval records when server is removed
Prevents orphaned ToolApprovalRecords from accumulating in the tool_approvals BBolt bucket when an upstream server is deleted. Follows the same pattern as ClearOAuthState cleanup.
1 parent aa19713 commit 9c3e554

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

internal/server/server.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1061,6 +1061,14 @@ func (s *Server) RemoveServer(ctx context.Context, serverName string) error {
10611061
zap.Error(err))
10621062
}
10631063

1064+
// Clean up tool approval records for the removed server
1065+
// This prevents orphaned approval records from accumulating
1066+
if err := storageManager.DeleteServerToolApprovals(serverName); err != nil {
1067+
s.logger.Warn("Failed to clear tool approvals for removed server",
1068+
zap.String("server", serverName),
1069+
zap.Error(err))
1070+
}
1071+
10641072
// Save configuration to file
10651073
if err := s.SaveConfiguration(); err != nil {
10661074
s.logger.Warn("Failed to save configuration after removing server",

0 commit comments

Comments
 (0)