Skip to content

Commit ad6c971

Browse files
committed
ci(065): widen eval.yml path-filter to cover the retrieval system
The eval gate only triggered on cmd/scan-eval, internal/security, and the datasets — so a change to the discovery system under test (search index, tokenizer, tool routing/ranking, tool descriptions) would silently skip the D1 retrieval + D2 security gates. Add the retrieval paths so the gate fires on discovery changes: - internal/index/** (Bleve BM25 index + tokenizer) - internal/server/mcp.go (retrieve_tools handler) - internal/server/mcp_routing.go (tool routing/ranking) - internal/server/mcp_annotations.go (tool annotations/descriptions) - cmd/mcpproxy/** (CLI + serve wiring) Addresses CodexReviewer request_changes on PR #561. Related #MCP-836
1 parent 0f11ec4 commit ad6c971

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

.github/workflows/eval.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,20 @@ name: Eval (Spec 065 regression gate)
1717
on:
1818
pull_request:
1919
paths:
20+
# D2 security gate — the scanner + detector code under test.
2021
- "cmd/scan-eval/**"
2122
- "internal/security/**"
23+
# D1 retrieval gate — the discovery system under test. Spec 065 requires
24+
# CI to catch recall/MRR/nDCG regressions when a maintainer changes the
25+
# search index, tokenizer, tool routing/ranking, or tool descriptions
26+
# (specs/065-evaluation-foundation/spec.md:22,24,61). Without these, a
27+
# retrieval change would silently skip the eval gate (MCP-836).
28+
- "internal/index/**" # Bleve BM25 index + tokenizer
29+
- "internal/server/mcp.go" # retrieve_tools handler
30+
- "internal/server/mcp_routing.go" # tool routing/ranking
31+
- "internal/server/mcp_annotations.go" # tool annotations/descriptions
32+
- "cmd/mcpproxy/**" # CLI + serve wiring
33+
# Shared: the frozen datasets, smoke harness, and this workflow itself.
2234
- "specs/065-evaluation-foundation/datasets/**"
2335
- "scripts/eval-ci-smoke.sh"
2436
- ".github/workflows/eval.yml"

0 commit comments

Comments
 (0)