Skip to content

Commit f7cbf40

Browse files
committed
Enhance log directory permission checks in tests for OS compatibility
- Updated TestEnsureLogDir to handle permission verification differently on Windows and Unix-like systems. - Ensured that directory checks are appropriate for the operating system's permission model.
1 parent 53fdb80 commit f7cbf40

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

internal/logs/paths_test.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,14 @@ func TestEnsureLogDir(t *testing.T) {
196196
require.NoError(t, err)
197197
assert.True(t, info.IsDir())
198198

199-
// Verify permissions (should be 0755)
200-
assert.Equal(t, os.FileMode(0755), info.Mode().Perm())
199+
// Verify permissions (Windows has different permission handling)
200+
if runtime.GOOS == "windows" {
201+
// On Windows, permissions are different and less granular
202+
assert.True(t, info.Mode().IsDir())
203+
} else {
204+
// On Unix-like systems, verify exact permissions (should be 0755)
205+
assert.Equal(t, os.FileMode(0755), info.Mode().Perm())
206+
}
201207
}
202208

203209
func TestGetLogFilePath(t *testing.T) {

0 commit comments

Comments
 (0)