Update dependencies and enhance secure environment management#12
Merged
Conversation
- Bump `github.com/mark3labs/mcp-go` dependency to v0.33.0. - Introduce `PathDiscovery` struct for managing discovered paths of common tools. - Implement path discovery methods for macOS, Windows, and Unix systems. - Enhance `Manager` to utilize discovered paths for building a comprehensive environment variable list. - Improve error handling and logging in the `Connect` method of the client.
- Update BuildSecureEnvironment method to conditionally enhance PATH based on InheritSystemSafe configuration. - Modify integration tests to assert inclusion of system paths in the enhanced PATH and ensure at least two safe system variables are filtered through.
- Update TestBuildSecureEnvironment to assert inclusion of system paths in the enhanced PATH using assert.Contains. - Improve TestRealWorldNpxScenario to verify enhanced path discovery for executables, providing clearer error messages.
- Update TestBuildSecureEnvironment and TestSecureEnvironmentIntegration to conditionally set PATH and HOME based on the operating system. - Improve TestGetSystemEnvVar and TestRealWorldNpxScenario to reflect platform-specific paths for better test accuracy. - Ensure consistent handling of environment variables across different OS environments.
- Update path patterns for Node.js, Python, Rust, and Go to use a more consistent format with slashes. - Modify discoverEnvironmentPaths method to improve clarity with named return values. - Enhance environment variable setting in buildEnvironmentSetupScript for better readability.
rannow
pushed a commit
to rannow/mcpproxy-go
that referenced
this pull request
Sep 23, 2025
…mcp-proxy#12) * Update dependencies and enhance secure environment management - Bump `github.com/mark3labs/mcp-go` dependency to v0.33.0. - Introduce `PathDiscovery` struct for managing discovered paths of common tools. - Implement path discovery methods for macOS, Windows, and Unix systems. - Enhance `Manager` to utilize discovered paths for building a comprehensive environment variable list. - Improve error handling and logging in the `Connect` method of the client. * Enhance secure environment PATH management - Update BuildSecureEnvironment method to conditionally enhance PATH based on InheritSystemSafe configuration. - Modify integration tests to assert inclusion of system paths in the enhanced PATH and ensure at least two safe system variables are filtered through. * Enhance tests for secure environment PATH validation - Update TestBuildSecureEnvironment to assert inclusion of system paths in the enhanced PATH using assert.Contains. - Improve TestRealWorldNpxScenario to verify enhanced path discovery for executables, providing clearer error messages. * Enhance platform-specific environment setup in tests - Update TestBuildSecureEnvironment and TestSecureEnvironmentIntegration to conditionally set PATH and HOME based on the operating system. - Improve TestGetSystemEnvVar and TestRealWorldNpxScenario to reflect platform-specific paths for better test accuracy. - Ensure consistent handling of environment variables across different OS environments. * Refactor path discovery for macOS in Manager and AutostartManager - Update path patterns for Node.js, Python, Rust, and Go to use a more consistent format with slashes. - Modify discoverEnvironmentPaths method to improve clarity with named return values. - Enhance environment variable setting in buildEnvironmentSetupScript for better readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/mark3labs/mcp-godependency to v0.33.0.PathDiscoverystruct for managing discovered paths of common tools.Managerto utilize discovered paths for building a comprehensive environment variable list.Connectmethod of the client.