Refactor secure environment management and enhance PATH handling#13
Merged
Conversation
Dumbris
commented
Jul 9, 2025
Dumbris
commented
Member
- Remove redundant path discovery methods and streamline the Manager's functionality.
- Update BuildSecureEnvironment to ensure PATH is inherited without enhancement.
- Modify tests to reflect changes in PATH handling and improve assertions for environment variables.
- Introduce command wrapping in a shell to respect user-defined PATH in GUI applications.
- Remove redundant path discovery methods and streamline the Manager's functionality. - Update BuildSecureEnvironment to ensure PATH is inherited without enhancement. - Modify tests to reflect changes in PATH handling and improve assertions for environment variables. - Introduce command wrapping in a shell to respect user-defined PATH in GUI applications.
rannow
pushed a commit
to rannow/mcpproxy-go
that referenced
this pull request
Sep 23, 2025
…rt-mcp-proxy#13) - Remove redundant path discovery methods and streamline the Manager's functionality. - Update BuildSecureEnvironment to ensure PATH is inherited without enhancement. - Modify tests to reflect changes in PATH handling and improve assertions for environment variables. - Introduce command wrapping in a shell to respect user-defined PATH in GUI applications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.