Add tests for SSE client connection and transport handling#15
Merged
Conversation
Dumbris
commented
Jul 9, 2025
Dumbris
commented
Member
- Introduced unit tests for SSE protocol connection scenarios in client_test.go.
- Enhanced error handling assertions to ensure connection failures are correctly identified.
- Updated client.go to support SSE transport creation with optional headers.
- Improved transport handling logic for different protocols, including HTTP and streamable-HTTP.
- Introduced unit tests for SSE protocol connection scenarios in client_test.go. - Enhanced error handling assertions to ensure connection failures are correctly identified. - Updated client.go to support SSE transport creation with optional headers. - Improved transport handling logic for different protocols, including HTTP and streamable-HTTP.
rannow
pushed a commit
to rannow/mcpproxy-go
that referenced
this pull request
Sep 23, 2025
…-proxy#15) - Introduced unit tests for SSE protocol connection scenarios in client_test.go. - Enhanced error handling assertions to ensure connection failures are correctly identified. - Updated client.go to support SSE transport creation with optional headers. - Improved transport handling logic for different protocols, including HTTP and streamable-HTTP.
technicalpickles
added a commit
to technicalpickles/mcpproxy-go
that referenced
this pull request
Dec 1, 2025
Added TestE2E_AuthStatus_AfterOAuthLogin to verify that token expiration logic correctly determines authentication state: Test Coverage: 1. Valid token verification: - Saves token with 1-hour expiration via PersistentTokenStore - Verifies token is retrievable and not expired - Validates authenticated=true logic - Confirms auth status would display '✅ Authenticated' 2. Expired token verification: - Saves token expired 1 hour ago - Verifies token is retrievable but expired - Validates authenticated=false logic - Confirms auth status would display '⏳ Pending Authentication' Key Implementation Details: - Uses PersistentTokenStore for realistic BBolt storage interaction - Tests token expiration validation logic (from config.go:207-222) - Simulates auth status command display logic (from auth_cmd.go:204-211) - Validates that isServerAuthenticated() helper correctly checks token state This ensures the 'mcpproxy auth status' command accurately shows OAuth authentication state based on actual token expiration, not just connection status. Part of PR smart-mcp-proxy#165 (zero-config OAuth with RFC 8707 support) - Task smart-mcp-proxy#15 completed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.