Add named Docker containers for upstream servers#54
Merged
Conversation
Implements container naming that includes upstream server names
to improve visibility and debugging in Docker Desktop and CLI.
Changes:
- Container names follow pattern: mcpproxy-{sanitizedServerName}-{4randomChars}
- Random 4-character suffix prevents conflicts between servers
- Server names are sanitized to comply with Docker naming rules
- Enhanced cleanup logic uses name patterns as primary method
- Fallback to existing image-based cleanup for compatibility
- Added comprehensive unit tests for naming and sanitization
- All linting issues resolved
Container names are now visible as "mcpproxy-github-server-a1b2"
instead of generic Docker-generated names, making it easier to
identify which containers belong to which upstream servers.
rannow
pushed a commit
to rannow/mcpproxy-go
that referenced
this pull request
Sep 23, 2025
…cker-names Add named Docker containers for upstream servers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements container naming that includes upstream server names to improve visibility and debugging in Docker Desktop and CLI tools.
Changes
mcpproxy-{sanitizedServerName}-{4randomChars}Benefits
Example
Container names are now visible as
mcpproxy-github-server-a1b2instead of generic Docker-generated names, making it easy to identify which containers belong to which upstream servers.Test plan