Enhance Docker container management and connection handling#59
Merged
Conversation
- Introduced a `connecting` flag in the Client struct to prevent concurrent connection attempts. - Added `containerName` field for better tracking and cleanup of Docker containers. - Implemented critical fixes for Docker container cleanup on connection and initialization failures. - Enhanced error handling and logging during reconnection attempts to avoid duplicate containers. - Added a method to kill Docker containers by exact name for improved cleanup accuracy. These changes improve the robustness of Docker integration and connection management, ensuring better resource handling and observability.
rannow
pushed a commit
to rannow/mcpproxy-go
that referenced
this pull request
Sep 23, 2025
…per-shutdown-servers Enhance Docker container management and connection handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connectingflag in the Client struct to prevent concurrent connection attempts.containerNamefield for better tracking and cleanup of Docker containers.These changes improve the robustness of Docker integration and connection management, ensuring better resource handling and observability.