docs(security): Spec 077 — scanner simplification (spec/plan/tasks)#784
Merged
Conversation
Planning package for making the deterministic offline detect engine the always-on default scanner and demoting the Docker scanners + source extraction to an opt-in deep scan that never blocks or degrades the baseline verdict, with a single unified report. - specs/077-scanner-simplification/spec.md: 4 user stories, 21 FRs, 8 SCs - plan.md: constitution check (all 6 principles), structure, complexity tracking - research.md: 8 grounded decisions (D1-D8) + alternatives - data-model.md + contracts/: unified report + security config schema - quickstart.md: 7 verification scenarios - CLAUDE.md: Recent Changes entry (speckit agent-context) Docs/spec-only; no code touched. Implementation follows via per-story PRs. Related: Spec 077 (specs/077-scanner-simplification)
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 28496544285 --repo smart-mcp-proxy/mcpproxy-go
|
Dumbris
added a commit
that referenced
this pull request
Jul 1, 2026
… (Spec 077 US1) Related #784 Related: Spec 077 (specs/077-scanner-simplification) The detect-corpus validator (specs/065-evaluation-foundation/datasets) hardcodes the set of coherent malicious categories and the gated-category coverage rules. Spec 077 US1 promoted phrase_injection to a real gated hard category (registered in cmd/scan-eval gateChecks + categoryCheck), so the validator must recognize it or reject the new corpus entries. ## Changes - validDetectCategory: accept malicious category "phrase_injection". - gatedDetectCategories: add "phrase_injection" (now measured by the gate; capability_mismatch stays excluded — soft/measured-not-gated). - hardNegPrefix: map "phrase_injection" -> "hn_phrase". - Rename the two branch-local phrase_injection hard-negatives (hn_send_email/hn_upload_file -> hn_phrase_*) to satisfy the id-prefix convention. Pre-existing corpus entries untouched (append-only respected). This STRENGTHENS coverage: the gate now requires phrase_injection to carry both malicious samples and resembling hard-negatives. ## Testing - go test ./... — all ok (exit 0); previously-failing TestDetectCorpus_SchemaAndProvenance + TestDetectCorpus_GatedCoverage pass. - scan-eval --gate — recall 1.0000, fp 0.0000 (phrase_injection gated 7/7). - golangci-lint v2 clean.
roadmap.yaml (from main via #785) references specs/077; regenerate the rendered view so the per-spec badge (0/42, drafted) and the epic status row reflect the spec landing in this PR. Keeps the roadmap-up-to-date CI check green. Related: Spec 077 (specs/077-scanner-simplification)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Planning package (spec → plan → tasks) for Spec 077 — Scanner Simplification: make the deterministic offline detect engine (Spec 076) the always-on default scanner that needs zero Docker, and demote the six Docker scanner plugins + source-code extraction to an opt-in deep scan that never blocks or degrades the baseline verdict. Findings from all scanners merge into a single unified report.
This PR is docs/spec-only — no code. Implementation lands via per-user-story PRs that reference this spec.
What's inside
specs/077-scanner-simplification/ScanReport/Finding/DeepScanDescriptor+security.deep_scanconfig schema.Key decisions
tpaRules+ legacy embedded-secret path; the detect engine is the sole in-process baseline.phrase_injectioncheck (curated high-confidence phrases); broader phrasing stays soft/review-only.security.deep_scanopt-in (off by default); baseline verdict is independent of deep-scan availability (no more confusing "degraded").Related: Spec 077 (specs/077-scanner-simplification)