chore(specs): gardener checkbox sync#824
Merged
Merged
Conversation
Deploying mcpproxy-docs with
|
| Latest commit: |
bbe0b08
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://32cf01b0.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://claude-spec-gardener.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 29077489930 --repo smart-mcp-proxy/mcpproxy-go
|
Dumbris
marked this pull request as ready for review
July 13, 2026 04:08
Dumbris
enabled auto-merge (squash)
July 13, 2026 04:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Automated spec-gardener run (2026-07-10): 5 checkbox ticks applied, 2 un-ticks proposed for human review. Ran
scripts/check-spec-evidence.pyacross all 57 specs, then adversarially verified everypossibly_built(tick candidate) andunresolved/removed(un-tick candidate) finding against the actual code before touching anything. Only- [ ]/- [x]checkbox characters inspecs/*/tasks.mdwere changed — no prose, no ROADMAP.md, no roadmap.yaml.Testing
git diffthat no other content changed)Applied ticks (5)
cmd/mcpproxy/auth_cmd.go:578-584—runAuthStatusClientModeprintsAuth URL:/Token URL:linesinternal/transport/http.go:200-203—logger.Debug("🔧 Using custom HTTP client with OAuth extra params wrapper", ...)when extra-params wrapper is activeinternal/oauth/config.go:956-964— "OAuth config created successfully" log includes structured fieldsscopes,redirect_uri,auth_server_metadata_url,registration_mode,discovery_mode,token_storecmd/mcpproxy/upstream_cmd_test.go:1375—TestOutputError_WithRequestID(labeled// T021)cmd/mcpproxy/upstream_cmd_test.go:1454—TestOutputError_WithoutRequestID(labeled// T022)Of the 147
possibly_builtcandidates the checker surfaced, the other 142 were dropped on verification (see below) — most were genuinely unimplemented, not just relocated.Proposed un-ticks (NOT applied)
[x]internal/security/detector_integration_test.godoes not exist; no deletion ingit log --diff-filter=D; no equivalent end-to-end secret-detection integration test exists anywhere underinternal/security/(the file's unit tests indetector_test.goand the scanner e2e tests underinternal/security/scannercover different specs, 076/077, not this one).[x]doctor --serverinvoking the REST/socket client and validating table/JSON/YAML output.cmd/mcpproxy/doctor_test.godoes not exist;doctor_cmd_test.goonly has output-formatting unit tests (TestOutputDiagnostics_*);doctor_fix_cmd_test.goonly has filtering tests (TestFilterDiagnosticsByServer_KeepsMatchingEntries). No single test (or combination) covers the--serverflag plus REST invocation plus all three output formats together.A human should confirm these two are genuinely missing (vs. covered by a test I didn't find) before un-ticking.
Dropped by verification
142
possibly_builtand 61unresolved/removedfindings were investigated and dropped — i.e. the checkbox state was left as-is because either (a) the unchecked task genuinely isn't done despite cited files existing (stub, skipped test, missing wiring), or (b) the checked task's artifact was found alive under a renamed/relocated file and the current checkbox is correct. Representative examples:internal/security/paths.goinstead ofinternal/security/patterns/files.go;internal/httpapi/activity.goinstead ofactivity_handlers.go;frontend/src/views/Activity.vueinstead ofActivityLogView.vue;cmd/mcpproxy/activity_cmd.go/activity_cmd_test.goinstead ofcmd/mcpproxy/commands/activity.go. 3 possibly-built tasks (T104/T108/T109 — E2E tests for custom patterns/SSE/API scenarios) remain genuinely unimplemented.oauthExpired,isAuthenticated,oauthError), badges ("Token Expired", "Auth Error"), and CLI flags/tests for OAuth logout simply don't exist inServerCard.vue/auth_cmd.go— the task prose describes work that was never done. One (T005) was a false-positive un-tick: the fields exist ininternal/contracts/types.gounder a different filename than cited.TestBuiltinToolCounterIncrementsPerCall,TestOAuthRefreshFailureRecordsErrorCategory) were never written, even though the underlying feature code exists; several investigative/"read and note" tasks (T001-T004) have no artifact to verify by nature.cmd/mcpproxy/teams_register.gowas renamed toserveredition_register.goas part of a repo-wide Teams→Server rename (confirmed viagit log); still gated by//go:build serverand importsinternal/serveredition— correctly still checked.Everything else in the 032, 040, 044-retention-telemetry-v3, 003-tool-annotations-webui, 019-activity-webui, 073-activity-size-retention, 057-in-proxy-profiles, 016-activity-log-backend, 022-oauth-redirect-uri-persistence, 012-docusaurus-docs-site, 010-release-notes-generator, 056-output-schema-validation, 011-resource-auto-detect, 005-rest-management-integration, 077-scanner-simplification, 076-deterministic-tool-scanner, and 044-diagnostics-taxonomy groups followed the same two patterns (genuinely unbuilt, or alive-but-relocated) and were dropped with no checkbox change.
Cap: 40 applied ticks per run — this run found only 5 that survived verification, well under the cap.