fix: overall status

Author: erikburt

actions/codeowners-analysis/dist/index.js

@@ -25620,21 +25620,27 @@ async function formatAllReviewsSummary(summary2) {
   for (const file of files) {
     const ownerStatuses = summary2.fileToStatus[file] || [];
     const owners = summary2.fileToOwners[file] && summary2.fileToOwners[file].length > 0 ? summary2.fileToOwners[file] : ["_No owners found_"];
-    const fileOverall = getOverallState(ownerStatuses);
     if (ownerStatuses.length === 0) {
+      const icon = owners.length === 0 ? iconFor("UNKNOWN") : iconFor("PENDING" /* Pending */);
       rows.push([
         { data: file },
-        { data: fileOverall ? iconFor(fileOverall) : "-" },
+        // filename
+        { data: icon },
+        // overall status
         { data: owners[0] ?? "_No owners found_" },
-        { data: "-" },
+        // owners
+        { data: icon },
+        // review state
         { data: "-" }
+        // reviewed by
       ]);
       continue;
     }
+    const fileOverall = getOverallState(ownerStatuses);
     const rowspan = String(ownerStatuses.length);
     const filenameCell = { data: file, rowspan };
     const overallCell = {
-      data: fileOverall ? iconFor(fileOverall) : "-",
+      data: iconFor(fileOverall),
       rowspan
     };
     ownerStatuses.forEach((status, idx) => {
@@ -25681,7 +25687,7 @@ function iconFor(state) {
   }
 }
 function getOverallState(statuses) {
-  if (!statuses || statuses.length === 0) return void 0;
+  if (!statuses || statuses.length === 0) return "PENDING" /* Pending */;
   const precedence = {
     ["CHANGES_REQUESTED" /* ChangesRequested */]: 0,
     ["APPROVED" /* Approved */]: 1,

actions/codeowners-analysis/src/strings.ts

@@ -69,23 +69,28 @@ export async function formatAllReviewsSummary(
         ? summary.fileToOwners[file]
         : ["_No owners found_"];
 
-    const fileOverall = getOverallState(ownerStatuses);
-
     if (ownerStatuses.length === 0) {
+      const icon =
+        owners.length === 0
+          ? iconFor("UNKNOWN")
+          : iconFor(PullRequestReviewState.Pending);
+
       rows.push([
-        { data: file },
-        { data: fileOverall ? iconFor(fileOverall) : "-" },
-        { data: owners[0] ?? "_No owners found_" },
-        { data: "-" },
-        { data: "-" },
+        { data: file }, // filename
+        { data: icon }, // overall status
+        { data: owners[0] ?? "_No owners found_" }, // owners
+        { data: icon }, // review state
+        { data: "-" }, // reviewed by
       ]);
       continue;
     }
 
+    const fileOverall = getOverallState(ownerStatuses);
+
     const rowspan = String(ownerStatuses.length);
     const filenameCell: TCell = { data: file, rowspan };
     const overallCell: TCell = {
-      data: fileOverall ? iconFor(fileOverall) : "-",
+      data: iconFor(fileOverall),
       rowspan,
     };
 
@@ -127,7 +132,7 @@ export async function formatAllReviewsSummary(
     .write();
 }
 
-function iconFor(state: PullRequestReviewState): string {
+function iconFor(state: PullRequestReviewState | "UNKNOWN"): string {
   switch (state) {
     case PullRequestReviewState.Approved:
       return "✅";
@@ -146,8 +151,8 @@ function iconFor(state: PullRequestReviewState): string {
 
 function getOverallState(
   statuses: OwnerReviewStatus[],
-): PullRequestReviewState | undefined {
-  if (!statuses || statuses.length === 0) return undefined;
+): PullRequestReviewState {
+  if (!statuses || statuses.length === 0) return PullRequestReviewState.Pending;
   const precedence: Record<PullRequestReviewState, number> = {
     [PullRequestReviewState.ChangesRequested]: 0,
     [PullRequestReviewState.Approved]: 1,