fix: go-mod-validator filter errored deps (#1452)

* fix: go-mod-validator filter errored deps

* fix: linting

Author: erikburt

.changeset/grumpy-icons-joke.md

@@ -0,0 +1,5 @@
+---
+"go-mod-validator": minor
+---
+
+fix: filter out errored dependenies

apps/go-mod-validator/dist/index.js

@@ -29681,7 +29681,15 @@ function lineForDependencyPathFinder() {
   };
 }
 function goModsToGoModules(goModFilePath, goMods, depPrefix) {
-  const goModules = goMods.map((d) => d.Replace || d).filter((d) => !d.Main && d.Path.startsWith(depPrefix)).map((d) => {
+  const goModules = goMods.map((d) => d.Replace || d).filter((d) => !d.Main && d.Path.startsWith(depPrefix)).filter((d) => {
+    if (d.Error && d.Error.Err) {
+      core.warning(
+        `Error loading module ${d.Path}: ${d.Error.Err}. This module will be skipped.`
+      );
+      return false;
+    }
+    return true;
+  }).map((d) => {
     const [_, owner, repo, ...subModulePathElements] = d.Path.split("/");
     const baseModule = {
       owner,

apps/go-mod-validator/src/deps.ts

@@ -292,6 +292,16 @@ export function goModsToGoModules(
     // `go list -m -json all` also lists the main package, avoid parsing it.
     // and only validate dependencies belonging to our org
     .filter((d) => !d.Main && d.Path.startsWith(depPrefix))
+    // filter any modules that may have errored because they are private
+    .filter((d) => {
+      if (d.Error && d.Error.Err) {
+        core.warning(
+          `Error loading module ${d.Path}: ${d.Error.Err}. This module will be skipped.`,
+        );
+        return false;
+      }
+      return true;
+    })
     .map((d: GoMod): GoModule => {
       // repo format github.com/smartcontractkit/chainlink
       const [_, owner, repo, ...subModulePathElements] = d.Path.split("/");

apps/go-mod-validator/test/deps.test.ts

@@ -1,6 +1,6 @@
 import { execSync } from "child_process";
 import { getDeps, getVersionType } from "../src/deps";
-import { describe, expect, it, vi, MockedObject } from "vitest";
+import { describe, expect, it, vi, MockedObject, beforeEach } from "vitest";
 import * as glob from "@actions/glob";
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -23,13 +23,24 @@ vi.mock("@actions/core", async (importOriginal: any) => ({
   },
 }));
 
+vi.mock("node:child_process", () => ({ execSync: vi.fn() }));
+vi.mock("@actions/glob", () => ({ create: vi.fn() }));
+
 const mockedExecSync = vi.mocked(execSync);
-vi.mock("child_process");
-const mockedGlob = vi.mocked(glob);
-vi.mock("@actions/glob");
+const mockedCreate = vi.mocked(glob.create);
+
+let getDeps: typeof import("../src/deps").getDeps;
 type MockedGlob = MockedObject<Awaited<ReturnType<typeof glob.create>>>;
 
 describe("getDependenciesMap", () => {
+  beforeEach(async () => {
+    vi.resetModules(); // <- key: clears module-level caching
+    vi.clearAllMocks();
+
+    // re-import AFTER resetModules so module-level singletons re-run
+    ({ getDeps } = await import("../src/deps"));
+  });
+
   it("should return a map of <go.mod files: dependencies in json>", async () => {
     const paths = ["/path/to/first/go.mod", "/path/to/second/go.mod"];
     const goList1 =
@@ -39,14 +50,17 @@ describe("getDependenciesMap", () => {
     const goList3 =
       '{"Path": "github.com/smartcontractkit/chainlink-protos/cre/go", "Version": "v1.0.0-beta"}';
 
-    mockedGlob.create.mockResolvedValueOnce({
+    mockedCreate.mockResolvedValueOnce({
       glob: vi.fn().mockResolvedValue(paths),
     } as MockedGlob);
 
     mockedExecSync.mockImplementationOnce(() => goList1);
     mockedExecSync.mockImplementationOnce(() => goList2 + "\n" + goList3);
 
     const result = await getDeps("", "github.com/smartcontractkit");
+
+    expect(mockedExecSync).toHaveBeenCalledTimes(2);
+
     expect(result).toMatchInlineSnapshot(`
       [
         {
@@ -80,18 +94,56 @@ describe("getDependenciesMap", () => {
     `);
   });
 
+  it("should skip dependencies with errors", async () => {
+    const paths = ["/path/to/first/go.mod"];
+    const goList1 =
+      '{"Path": "github.com/smartcontractkit/go-plugin", "Version": "v0.0.0-20240208201424-b3b91517de16"}';
+    const goList2 = `
+{
+  "Path": "github.com/smartcontractkit/private-dep",
+  "Version": "v0.0.0-20260224170222-a43bd3ff9dd5",
+  "Error": {
+    "Err": "github.com/smartcontractkit/private-dep@v0.0.0-20260224170222-a43bd3ff9dd5: invalid version: git ls-remote -q --end-of-options https://github.com/smartcontractkit/private-dep in /go/pkg/mod/cache/vcs/94d9727765b1ab36ed05d10c5d35ca726794e132cb25bee11cb34a7d6107b004: exit status 128:\\n\\tfatal: could not read Username for 'https://github.com': terminal prompts disabled\\nConfirm the import path was entered correctly.\\nIf this is a private repository, see https://golang.org/doc/faq#git_https for additional information."
+  }
+}`;
+
+    mockedCreate.mockResolvedValueOnce({
+      glob: vi.fn().mockResolvedValue(paths),
+    } as MockedGlob);
+
+    mockedExecSync.mockImplementationOnce(() => goList1 + "\n" + goList2);
+
+    const result = await getDeps("", "github.com/smartcontractkit");
+
+    expect(mockedExecSync).toHaveBeenCalledTimes(1);
+
+    expect(result).toMatchInlineSnapshot(`
+      [
+        {
+          "commitSha": "b3b91517de16",
+          "goModFilePath": "/path/to/first/go.mod",
+          "name": "github.com/smartcontractkit/go-plugin@v0.0.0-20240208201424-b3b91517de16",
+          "owner": "smartcontractkit",
+          "path": "github.com/smartcontractkit/go-plugin",
+          "repo": "go-plugin",
+          "version": "v0.0.0-20240208201424-b3b91517de16",
+        },
+      ]
+    `);
+  });
+
   it("should handle no go.mod files found", async () => {
     const paths: string[] = [];
 
-    mockedGlob.create.mockResolvedValue({
+    mockedCreate.mockResolvedValue({
       glob: vi.fn().mockResolvedValue(paths),
     } as MockedGlob);
 
     await expect(getDeps("", "")).rejects.toThrow("no go.mod files found");
   });
 
   it("should handle glob search failure", async () => {
-    mockedGlob.create.mockRejectedValue(new Error("Glob error"));
+    mockedCreate.mockRejectedValue(new Error("Glob error"));
     await expect(getDeps("", "")).rejects.toThrow("Glob error");
   });
 });

apps/go-mod-validator/test/github.test.ts

@@ -156,8 +156,13 @@ describe("isGoModReferencingBranch", () => {
       const errMsg = "not found";
       mockOctokit.rest.git.getRef.mockRejectedValue(errMsg);
 
-      const result = isGoModReferencingBranch(mockOctokit, goMod, "main", {});
-      expect(result).resolves.toEqual({
+      const result = await isGoModReferencingBranch(
+        mockOctokit,
+        goMod,
+        "main",
+        {},
+      );
+      expect(result).toEqual({
         isInBranch: "unknown",
         commitSha: "",
         reason: errMsg,