Skip to content

fix: build-push-docker layer caching#1484

Merged
erikburt merged 7 commits intomainfrom
test/ctf-build-image-docker-caching
Mar 25, 2026
Merged

fix: build-push-docker layer caching#1484
erikburt merged 7 commits intomainfrom
test/ctf-build-image-docker-caching

Conversation

@erikburt
Copy link
Copy Markdown
Contributor

@erikburt erikburt commented Mar 25, 2026

Fixes build-push-docker caching setup and optimizes ctf-build-image's usage of it.

Changes

build-push-docker

  • Actually just fix caching, was completely broken before
  • Default restore cache to false (there were no usages of these cache parameters anywhere, so this should have no effect)
  • Rework the cache-to/cache-from inputs so they:
    • Are now defaulted in the shell script if cache restore/save is enabled
    • don't modify the parameters as it complicates it, let the caller fully choose the cache-to/cache-from
  • Update to latest docker/build-push-action v7.0.0 (node24)

ctf-build-image

  • pass proper caching configuration to build-push-docker

Testing

smartcontractkit/chainlink#21700


DX-3570

@erikburt erikburt self-assigned this Mar 25, 2026
kalverra
kalverra previously approved these changes Mar 25, 2026
@erikburt erikburt changed the title test: integ test docker cache fix: build-push-docker layer caching Mar 25, 2026
@erikburt erikburt marked this pull request as ready for review March 25, 2026 20:10
@erikburt erikburt requested a review from a team as a code owner March 25, 2026 20:10
@erikburt erikburt requested a review from kalverra March 25, 2026 20:10
@erikburt erikburt merged commit 3315e6d into main Mar 25, 2026
17 checks passed
@erikburt erikburt deleted the test/ctf-build-image-docker-caching branch March 25, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants