Skip to content

feat: reusable-docker-build-publish allow-overwrites #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikburt merged 3 commits into from
Apr 29, 2026
Merged

feat: reusable-docker-build-publish allow-overwrites #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcee036
feat: reusable-docker-build-publish allow-overwrites
erikburt Apr 27, 2026
1fa56c9
Merge branch 'main' into feat/reusable-docker-allow-overwrites
erikburt Apr 27, 2026
569fa20
Merge branch 'main' into feat/reusable-docker-allow-overwrites
erikburt Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/clean-rules-dream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"reusable-docker-build-publish": minor
---

feat: add "allow-overwrites" input. See `build-push-docker` action for more
details
8 changes: 8 additions & 0 deletions .github/workflows/reusable-docker-build-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,13 @@
required: false
type: string
default: "false"
allow-overwrites:
description: |
Whether to allow overwriting existing Docker images with the same tag in AWS ECR.
Default is true (for backwards compatibility).
required: false
type: string
default: "true"

outputs:
docker-image-sha-digest-amd64:
Expand Down Expand Up @@ -507,7 +514,7 @@
environment:
name: ${{ inputs.environment }}
# http://docs.github.com/en/actions/how-tos/deploy/configure-and-manage-deployments/control-deployments#using-environments-without-deployments
deployment: false

Check failure on line 517 in .github/workflows/reusable-docker-build-publish.yml

View workflow job for this annotation

GitHub Actions / ci-lint-misc 

[actionlint] reported by reviewdog 🐶
unexpected key "deployment" for "environment" section. expected one of "name", "url" [syntax-check]

Raw Output:
e:.github/workflows/reusable-docker-build-publish.yml:517:7: unexpected key "deployment" for "environment" section. expected one of "name", "url" [syntax-check]
runs-on: ${{ matrix.runner }}
timeout-minutes: ${{ inputs.timeout }}
strategy:
Expand Down Expand Up @@ -664,6 +671,7 @@
aws-role-arn: ${{ secrets.AWS_ROLE_PUBLISH_ARN }}
aws-region: ${{ inputs.aws-region-ecr }}
github-token: ${{ secrets.GITHUB_TOKEN_DOCKER_BUILD_OVERRIDE || steps.token.outputs.access-token || '' }}
allow-overwrites: ${{ inputs.allow-overwrites }}

docker-manifest:
name: docker-manifest
Expand All @@ -672,7 +680,7 @@
environment:
name: ${{ inputs.environment }}
# http://docs.github.com/en/actions/how-tos/deploy/configure-and-manage-deployments/control-deployments#using-environments-without-deployments
deployment: false

Check failure on line 683 in .github/workflows/reusable-docker-build-publish.yml

View workflow job for this annotation

GitHub Actions / ci-lint-misc 

[actionlint] reported by reviewdog 🐶
unexpected key "deployment" for "environment" section. expected one of "name", "url" [syntax-check]

Raw Output:
e:.github/workflows/reusable-docker-build-publish.yml:683:7: unexpected key "deployment" for "environment" section. expected one of "name", "url" [syntax-check]
runs-on: ubuntu-24.04
timeout-minutes: 5
outputs:
Expand Down
8 changes: 8 additions & 0 deletions workflows/reusable-docker-build-publish/reusable-docker-build-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,13 @@ on:
required: false
type: string
default: "false"
allow-overwrites:
description: |
Whether to allow overwriting existing Docker images with the same tag in AWS ECR.
Default is true (for backwards compatibility).
required: false
type: string
default: "true"

outputs:
docker-image-sha-digest-amd64:
Expand Down Expand Up @@ -660,6 +667,7 @@ jobs:
aws-role-arn: ${{ secrets.AWS_ROLE_PUBLISH_ARN }}
aws-region: ${{ inputs.aws-region-ecr }}
github-token: ${{ secrets.GITHUB_TOKEN_DOCKER_BUILD_OVERRIDE || steps.token.outputs.access-token || '' }}
allow-overwrites: ${{ inputs.allow-overwrites }}

docker-manifest:
name: docker-manifest
Expand Down
Loading