Skip to content

integration-tests/deploy: make container names unique#302

Open
jmank88 wants to merge 2 commits into
developfrom
pkg-concurrency
Open

integration-tests/deploy: make container names unique#302
jmank88 wants to merge 2 commits into
developfrom
pkg-concurrency

Conversation

@jmank88

@jmank88 jmank88 commented Sep 15, 2025

Copy link
Copy Markdown
Collaborator

Unique container names in order to allow testing packages concurrently.

@jmank88 jmank88 requested a review from a team as a code owner September 15, 2025 11:55
@github-actions

github-actions Bot commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

👋 jmank88, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

jmank88
jmank88 commented Sep 15, 2025
View reviewed changes
Comment thread integration-tests/deploy/config.go
func ValidateDevnet() (*DevnetConfig, error) {
var errs []string
name := "chainlink-aptos.devnet"
if testing.Testing() {

@jmank88 jmank88 Sep 15, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it doesn't need to be conditional on testing, though this is sufficient.

@github-actions

github-actions Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open days with no activity.
Remove the stale label, comment, or update this PR to prevent this PR from being closed in days.

@github-actions github-actions Bot added the Stale label Feb 27, 2026
@jmank88 jmank88 removed the Stale label Mar 2, 2026
@github-actions

github-actions Bot commented May 2, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open days with no activity.
Remove the stale label, comment, or update this PR to prevent this PR from being closed in days.

@github-actions github-actions Bot added the Stale label May 2, 2026
@jmank88 jmank88 removed the Stale label May 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open days with no activity.
Remove the stale label, comment, or update this PR to prevent this PR from being closed in days.

@github-actions github-actions Bot added the Stale label Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smickovskid smickovskid Awaiting requested review from smickovskid
@friedemannf friedemannf Awaiting requested review from friedemannf
@krebernisak krebernisak Awaiting requested review from krebernisak
@archseer archseer Awaiting requested review from archseer

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jmank88