feat: tooling API set token pool token transfer fees 2.0#1931
Merged
chris-de-leon-cll merged 36 commits intomainfrom Apr 7, 2026
Merged
feat: tooling API set token pool token transfer fees 2.0#1931chris-de-leon-cll merged 36 commits intomainfrom
chris-de-leon-cll merged 36 commits intomainfrom
Conversation
…contractkit/chainlink-ccip into feat/tp-token-transfer-fee-configs
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new token-pool (v2) token transfer fee configuration changeset and updates the existing Fee Quoter fee changeset to use the new utils.Optional + Resolve flow and patch-stripped adapter lookups.
Changes:
- Introduce
deployment/tokens.SetTokenTransferFeesupporting per-pool min block confirmations and per-destination fee config with merge-from-onchain-or-defaults behavior. - Add EVM v1_7_0 token adapter + sequences to apply token-pool fee configs and min block confirmations on-chain.
- Update Fee Quoter
SetTokenTransferFeeto useutils.Optional,Resolve,StripPatchVersion, and trimmed-address deduping; add/adjust integration tests.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| integration-tests/go.mod | Adds local module requirement for ccv/chains/evm/deployment used by new integration tests. |
| integration-tests/go.sum | Updates sums for new dependencies. |
| integration-tests/deployment/set_token_transfer_fee_test.go | Refactors existing fee tests and adds new coverage for v2 token pool fee config + min confirmations. |
| go.md | Updates module relationship diagram to reflect new dependency path. |
| deployment/utils/optional.go | Adds generic Optional[T] type and helpers for partial updates. |
| deployment/utils/common.go | Adds StripPatchVersion helper for adapter registry lookups. |
| deployment/tokens/product.go | Introduces TokenFeeAdapter interface and sequence input types for token-pool fee updates. |
| deployment/tokens/fees.go | Implements new token-pool fee changeset (verify/apply + onchain/default merge). |
| deployment/fees/models.go | Replaces prior “Infer” value wrapper with utils.Optional + Resolve. |
| deployment/fees/set_token_transfer_fee.go | Uses StripPatchVersion, Resolve, and trimmed-address dedupe in verify. |
| ccv/chains/evm/deployment/v1_7_0/sequences/tokens/set_min_block_confirmations_for_token_pools.go | New sequence to set token-pool min block confirmations. |
| ccv/chains/evm/deployment/v1_7_0/sequences/tokens/set_token_transfer_fee_config_for_token_pools.go | New sequence to set/disable per-destination token transfer fee configs for pools. |
| ccv/chains/evm/deployment/v1_7_0/sequences/tokens/configure_token_for_transfers.go | Resolves TokenAdminRegistry address from datastore when not provided. |
| ccv/chains/evm/deployment/v1_7_0/adapters/tokens.go | Extends EVM v1_7_0 token adapter to implement TokenFeeAdapter (set + query fee configs). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tt-cll
previously approved these changes
Apr 7, 2026
tt-cll
approved these changes
Apr 7, 2026
|
sowgandhi11
approved these changes
Apr 7, 2026
0xsuryansh
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
deployment/tokens.SetTokenTransferFeefor v2 token pools (optional min block confirmations, per-destination fee config, merge with on-chain or defaults) viaTokenFeeAdapterFee Quoter
SetTokenTransferFeenow usesutils.Optional,Resolveinstead ofInfer,StripPatchVersionfor adapter lookup, and dedupes token addresses per(src, dst)using trimmed strings.Checklist:
minBlockConfirmationstokens_and_token_pools_test.go?feesadapter?