Skip to content

aggregator/pkg/handlers: fix post-teardown log panic #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
makramkd merged 3 commits into from
Jun 9, 2026
Merged

aggregator/pkg/handlers: fix post-teardown log panic #1167

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0cf288
aggregator/pkg/handlers: fix post-teardown log panic
makramkd Jun 9, 2026
aca37db
lint
makramkd Jun 9, 2026
bb14b55
use logger.Nop() in rest of tests
makramkd Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions aggregator/pkg/handlers/batch_write_commit_verifier_node_result_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func TestBatchWriteCommitCCVNodeDataHandler_BatchSizeValidation(t *testing.T) {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()

lggr := logger.TestSugared(t)
lggr := logger.Sugared(logger.Nop())
store := mocks.NewMockCommitVerificationStore(t)
agg := mocks.NewMockAggregationTriggerer(t)
sig := mocks.NewMockSignatureValidator(t)
Expand Down Expand Up @@ -119,7 +119,7 @@ func TestBatchWriteCommitCCVNodeDataHandler_MixedSuccessAndInvalidArgument(t *te
const testCallerID = "test-caller"
const testChannelKey model.ChannelKey = "test-caller"

lggr := logger.TestSugared(t)
lggr := logger.Sugared(logger.Nop())
store := mocks.NewMockCommitVerificationStore(t)
agg := mocks.NewMockAggregationTriggerer(t)

Expand Down Expand Up @@ -174,7 +174,7 @@ func TestBatchWriteCommitCCVNodeDataHandler_NilRequestAtIndexReturnsInvalidArgum
const testCallerID = "test-caller"
const testChannelKey model.ChannelKey = "test-caller"

lggr := logger.TestSugared(t)
lggr := logger.Sugared(logger.Nop())
store := mocks.NewMockCommitVerificationStore(t)
agg := mocks.NewMockAggregationTriggerer(t)
sig := mocks.NewMockSignatureValidator(t)
Expand Down Expand Up @@ -225,7 +225,10 @@ func TestBatchWriteCommitCCVNodeDataHandler_CancelledContextReturnsImmediately(t
const testChannelKey model.ChannelKey = "test-caller"
blockDuration := 5 * time.Second

lggr := logger.TestSugared(t)
// Use a nop logger: worker goroutines that are still running when the context
// is canceled may log after this test's *testing.T is torn down, which
// panics in Go. A nop logger avoids that without changing the handler.
lggr := logger.Sugared(logger.Nop())
store := mocks.NewMockCommitVerificationStore(t)
agg := mocks.NewMockAggregationTriggerer(t)
sig := mocks.NewMockSignatureValidator(t)
Expand Down
Loading