fix: tmp no strict bootstrap config parsing#1232
Merged
Merged
Conversation
bukata-sa
force-pushed
the
fix/bootstrap-config-no-strict
branch
from
6ff184a to
64b6330
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Temporarily relaxes bootstrap TOML parsing to allow config migrations to proceed without failing on unknown/undecoded fields.
Changes:
- Switches bootstrap config loading from strict TOML decoding to a non-strict decode path.
- Replaces
parseTOMLStrictwith aparseTOML(..., strict bool)helper and gates the undecoded-fields error behind thestrictflag.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
215
to
216
| func parseTOML[T any](tomlString string, out T, strict bool) error { | ||
| md, err := toml.Decode(tomlString, out) |
makramkd
previously approved these changes
Jul 3, 2026
|
Code coverage report:
|
carte7000
approved these changes
Jul 3, 2026
flodesi
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable bootstrap tmpl config strict mode parsing to allow deploying pods with old monitoring config layout
Testing
CI checks
Checklist
changelogdirectory)just lint fix- no new lint errorsjust generate- mocks and protobufs are up to date