Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors EVM chain registration to be registry/factory-driven rather than having EVM-specific branches embedded in environment/lib setup.
Changes:
- Removed the inline EVM implementation construction in
Lib.Chains()and consistently instantiate chain implementations viaImplFactory. - Added an EVM
ImplFactoryplus a CLDF provider factory registration hook (init()) to centralize EVM wiring. - Moved EVM CLDF provider creation out of
NewCLDFOperationsEnvironmentWithOffchain()to the CLDF provider registry and adjusted config helpers accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| build/devenv/lib.go | Removes the EVM special-case in chain impl creation; uses GetImplFactory uniformly. |
| build/devenv/evm_factory.go | Introduces EVM ImplFactory + registers an EVM CLDF provider factory. |
| build/devenv/environment.go | Resolves product config creation via family factory; adjusts EVM key checks and clarifies comments. |
| build/devenv/cldf.go | Removes inline EVM CLDF provider setup and uses the CLDF provider registry for non-Canton families. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Code coverage report:
|
makramkd
approved these changes
Apr 6, 2026
Comment on lines
+1078
to
+1079
| // A future improvement: add a GetTokenTransferConfigs() method to CCIP17Configuration so each | ||
| // chain impl provides its own token configs, rather than using a centralized BuildTokenTransferConfigs. |
carte7000
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.