Add Solana chain family to enrichEnvironmentTopology#999
Conversation
ogtownsend
changed the title
There was a problem hiding this comment.
Pull request overview
Extends enrichEnvironmentTopology so NOP signer addresses can be populated for Solana-family chains, reusing the existing EVM signer identity in standalone (non-CL) mode.
Changes:
- Refactors EVM signer lookup to a local
evmSignervariable and persists it when missing. - Adds Solana chain-family signer address population, defaulting to the EVM signer.
- Removes an outdated/duplicate inline comment in JD bootstrap registration flow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Code coverage report:
|
tt-cll
left a comment
tt-cll
left a comment
There was a problem hiding this comment.
this is the pattern for now, so the change is fine, but maybe this chain specific registration in the centralized location is something we can abstract soon cc @0xAustinWang @winder @makramkd
|
@tt-cll yeah I think we need a proper registration approach for this and potentially transmitter key as well: https://github.com/smartcontractkit/chainlink-ccv/blob/main/build/devenv/services/executor/base.go#L561-L580 |
We will reuse EVM verifier signing keys for Solana messages