extend interface

Author: tarcisiozf

pkg/beholder/chip_ingress_emitter.go

@@ -26,10 +26,7 @@ func (c *ChipIngressEmitter) Close() error {
 }
 
 func (c *ChipIngressEmitter) Emit(ctx context.Context, body []byte, attrKVs ...any) error {
-	return c.BatchEmit(ctx, Message{
-		Body:  body,
-		Attrs: ExtractAttributes(attrKVs...),
-	})
+	return c.BatchEmit(ctx, NewMessage(body, attrKVs...))
 }
 
 func (c *ChipIngressEmitter) BatchEmit(ctx context.Context, messages ...Message) error {

pkg/beholder/client.go

@@ -31,8 +31,9 @@ import (
 const defaultGRPCCompressor = "gzip"
 
 type Emitter interface {
-	// Sends message with bytes and attributes to OTel Collector
+	// Emit Sends message with bytes and attributes to OTel Collector
 	Emit(ctx context.Context, body []byte, attrKVs ...any) error
+	BatchEmit(ctx context.Context, messages ...Message) error
 	io.Closer
 }
 

pkg/beholder/message_emitter.go

@@ -22,10 +22,15 @@ func (e messageEmitter) Close() error { return nil }
 // Emits logs the message, but does not wait for the message to be processed.
 // Open question: what are pros/cons for using use map[]any vs use otellog.KeyValue
 func (e messageEmitter) Emit(ctx context.Context, body []byte, attrKVs ...any) error {
-	message := NewMessage(body, attrKVs...)
-	if err := message.Validate(); err != nil {
-		return err
+	return e.BatchEmit(ctx, NewMessage(body, attrKVs...))
+}
+
+func (e messageEmitter) BatchEmit(ctx context.Context, messages ...Message) error {
+	for _, message := range messages {
+		if err := message.Validate(); err != nil {
+			return err
+		}
+		e.messageLogger.Emit(ctx, message.OtelRecord())
 	}
-	e.messageLogger.Emit(ctx, message.OtelRecord())
 	return nil
 }