Fix tests

Author: DylanTinianov

pkg/capabilities/base_trigger_test.go

@@ -21,7 +21,7 @@ func TestResolveBaseTriggerRetryInterval(t *testing.T) {
 	t.Run("nil getter uses defaults", func(t *testing.T) {
 		d, err := ResolveBaseTriggerRetryInterval(ctx, nil, lggr)
 		require.NoError(t, err)
-		require.Equal(t, 30*time.Second, d)
+		require.Zero(t, d, "default BaseTriggerRetransmitEnabled is false, so retry interval is disabled")
 	})
 
 	t.Run("global JSON enables interval", func(t *testing.T) {

pkg/settings/cresettings/defaults.toml

@@ -7,7 +7,7 @@ VaultOrgIdAsSecretOwnerEnabled = 'false'
 GatewayHTTPGlobalRate = '500rps:500'
 GatewayHTTPPerNodeRate = '100rps:100'
 TriggerRegistrationStatusUpdateTimeout = '0s'
-BaseTriggerRetransmitEnabled = 'true'
+BaseTriggerRetransmitEnabled = 'false'
 BaseTriggerRetryInterval = '30s'
 VaultCiphertextSizeLimit = '2kb'
 VaultShareSizeLimit = '600b'

pkg/settings/cresettings/settings.go

@@ -61,7 +61,7 @@ var Default = Schema{
 	GatewayHTTPGlobalRate:                  Rate(rate.Limit(500), 500),
 	GatewayHTTPPerNodeRate:                 Rate(rate.Limit(100), 100),
 	TriggerRegistrationStatusUpdateTimeout: Duration(0 * time.Second),
-	BaseTriggerRetransmitEnabled:           Bool(true),
+	BaseTriggerRetransmitEnabled:           Bool(false),
 	BaseTriggerRetryInterval:               Duration(30 * time.Second),
 
 	// DANGER(cedric): Be extremely careful changing these vault limits as they act as a default value