bumping protos + PR feedback

Author: patrickhuie19

pkg/billing/workflow_client.go

@@ -11,10 +11,10 @@ import (
 	"google.golang.org/grpc/metadata"
 	"google.golang.org/protobuf/types/known/emptypb"
 
+	"github.com/smartcontractkit/chainlink-common/pkg/logger"
+	nodeauthgrpc "github.com/smartcontractkit/chainlink-common/pkg/nodeauth/grpc"
 	auth "github.com/smartcontractkit/chainlink-common/pkg/nodeauth/jwt"
 	pb "github.com/smartcontractkit/chainlink-protos/billing/go"
-
-	"github.com/smartcontractkit/chainlink-common/pkg/logger"
 )
 
 // WorkflowClient is a specialized interface for the Workflow node use-case.
@@ -139,7 +139,7 @@ func (wc *workflowClient) addJWTAuth(ctx context.Context, req any) (context.Cont
 	}
 
 	// Add JWT to Authorization header
-	return metadata.AppendToOutgoingContext(ctx, "authorization", "Bearer "+jwtToken), nil
+	return metadata.AppendToOutgoingContext(ctx, nodeauthgrpc.AuthorizationHeader, nodeauthgrpc.BearerPrefix+jwtToken), nil
 }
 
 func (wc *workflowClient) GetOrganizationCreditsByWorkflow(ctx context.Context, req *pb.GetOrganizationCreditsByWorkflowRequest) (*pb.GetOrganizationCreditsByWorkflowResponse, error) {

pkg/services/orgresolver/linking.go

@@ -11,6 +11,7 @@ import (
 	"google.golang.org/grpc/metadata"
 
 	log "github.com/smartcontractkit/chainlink-common/pkg/logger"
+	nodeauthgrpc "github.com/smartcontractkit/chainlink-common/pkg/nodeauth/grpc"
 	"github.com/smartcontractkit/chainlink-common/pkg/services"
 	linkingclient "github.com/smartcontractkit/chainlink-protos/linking-service/go/v1"
 )
@@ -100,7 +101,7 @@ func (o *orgResolver) addJWTAuth(ctx context.Context, req any) (context.Context,
 	}
 
 	// Add JWT to Authorization header
-	return metadata.AppendToOutgoingContext(ctx, "authorization", "Bearer "+jwtToken), nil
+	return metadata.AppendToOutgoingContext(ctx, nodeauthgrpc.AuthorizationHeader, nodeauthgrpc.BearerPrefix+jwtToken), nil
 }
 
 func (o *orgResolver) Get(ctx context.Context, owner string) (string, error) {

pkg/workflows/grpcsource/client.go

@@ -10,9 +10,9 @@ import (
 	"google.golang.org/grpc/credentials/insecure"
 	"google.golang.org/grpc/metadata"
 
-	pb "github.com/smartcontractkit/chainlink-protos/workflows/go/sources"
-
+	nodeauthgrpc "github.com/smartcontractkit/chainlink-common/pkg/nodeauth/grpc"
 	auth "github.com/smartcontractkit/chainlink-common/pkg/nodeauth/jwt"
+	pb "github.com/smartcontractkit/chainlink-protos/workflows/go/sources"
 )
 
 // Client is a GRPC client for the WorkflowMetadataSourceService.
@@ -99,7 +99,7 @@ func (c *Client) addJWTAuth(ctx context.Context, req any) (context.Context, erro
 		return nil, fmt.Errorf("failed to create JWT: %w", err)
 	}
 
-	return metadata.AppendToOutgoingContext(ctx, "authorization", "Bearer "+jwtToken), nil
+	return metadata.AppendToOutgoingContext(ctx, nodeauthgrpc.AuthorizationHeader, nodeauthgrpc.BearerPrefix+jwtToken), nil
 }
 
 // ListWorkflowMetadata fetches workflow metadata from the GRPC source.

pkg/workflows/privateregistry/types.go

@@ -10,7 +10,6 @@ type WorkflowDeploymentAction interface {
 	AddWorkflow(ctx context.Context, workflow *WorkflowRegistration) error
 
 	// UpdateWorkflow updates the workflow's status configuration
-	// This is idempotent - calling with the same config multiple times has the same effect
 	UpdateWorkflow(ctx context.Context, workflowID [32]byte, config *WorkflowStatusConfig) error
 
 	// DeleteWorkflow removes the workflow from the source