fix linter issues

Author: jmank88

observability-lib/grafana/businessvariable/panel_builder.go

@@ -92,7 +92,7 @@ func (builder *PanelBuilder) GridPos(gridPos dashboard.GridPos) *PanelBuilder {
 
 // Panel height. The height is the number of rows from the top edge of the panel.
 func (builder *PanelBuilder) Height(h uint32) *PanelBuilder {
-	if !(h > 0) {
+	if h <= 0 {
 		builder.errors["h"] = cog.MakeBuildErrors("h", errors.New("h must be > 0"))
 		return builder
 	}
@@ -106,11 +106,11 @@ func (builder *PanelBuilder) Height(h uint32) *PanelBuilder {
 
 // Panel width. The width is the number of columns from the left edge of the panel.
 func (builder *PanelBuilder) Span(w uint32) *PanelBuilder {
-	if !(w > 0) {
+	if w <= 0 {
 		builder.errors["w"] = cog.MakeBuildErrors("w", errors.New("w must be > 0"))
 		return builder
 	}
-	if !(w <= 24) {
+	if w > 24 {
 		builder.errors["w"] = cog.MakeBuildErrors("w", errors.New("w must be <= 24"))
 		return builder
 	}

observability-lib/grafana/polystat/panel_builder.go

@@ -93,7 +93,7 @@ func (builder *PanelBuilder) GridPos(gridPos dashboard.GridPos) *PanelBuilder {
 
 // Panel height. The height is the number of rows from the top edge of the panel.
 func (builder *PanelBuilder) Height(h uint32) *PanelBuilder {
-	if !(h > 0) {
+	if h <= 0 {
 		builder.errors["h"] = cog.MakeBuildErrors("h", errors.New("h must be > 0"))
 		return builder
 	}
@@ -107,11 +107,11 @@ func (builder *PanelBuilder) Height(h uint32) *PanelBuilder {
 
 // Panel width. The width is the number of columns from the left edge of the panel.
 func (builder *PanelBuilder) Span(w uint32) *PanelBuilder {
-	if !(w > 0) {
+	if w <= 0 {
 		builder.errors["w"] = cog.MakeBuildErrors("w", errors.New("w must be > 0"))
 		return builder
 	}
-	if !(w <= 24) {
+	if w > 24 {
 		builder.errors["w"] = cog.MakeBuildErrors("w", errors.New("w must be <= 24"))
 		return builder
 	}

pkg/beholder/client_test.go

@@ -495,9 +495,6 @@ func TestNewClient_Chip(t *testing.T) {
 		assert.NotNil(t, client)
 		assert.NotNil(t, client.Chip)
 
-		// Verify it implements the Client interface
-		var _ chipingress.Client = client.Chip
-
 		// Verify the emitter is configured as dual source
 		assert.NotNil(t, client.Emitter)
 		assert.IsType(t, &beholder.DualSourceEmitter{}, client.Emitter)
@@ -514,9 +511,6 @@ func TestNewClient_Chip(t *testing.T) {
 		assert.NotNil(t, client)
 		assert.NotNil(t, client.Chip)
 
-		// Verify it implements the Client interface
-		var _ chipingress.Client = client.Chip
-
 		// Verify emitter is not dual source when dual emitter is disabled
 		assert.NotNil(t, client.Emitter)
 	})

pkg/beholder/global_test.go

@@ -33,13 +33,12 @@ func TestGlobal(t *testing.T) {
 	expectedMessageEmitter := beholder.NewNoopClient().Emitter
 	assert.IsType(t, expectedMessageEmitter, messageEmitter)
 
-	var noopClientPtr *beholder.Client = noopClient
-	assert.IsType(t, noopClientPtr, beholder.GetClient())
-	assert.NotSame(t, noopClientPtr, beholder.GetClient())
+	assert.IsType(t, noopClient, beholder.GetClient())
+	assert.NotSame(t, noopClient, beholder.GetClient())
 
 	// Set beholder client so it will be accessible from anywhere through beholder functions
-	beholder.SetClient(noopClientPtr)
-	assert.Same(t, noopClientPtr, beholder.GetClient())
+	beholder.SetClient(noopClient)
+	assert.Same(t, noopClient, beholder.GetClient())
 
 	// After that use beholder functions to get logger, tracer, meter, messageEmitter
 	logger, tracer, meter, messageEmitter = beholder.GetLogger(), beholder.GetTracer(), beholder.GetMeter(), beholder.GetEmitter()

pkg/beholder/noop_test.go

@@ -55,7 +55,6 @@ func TestNoopClient(t *testing.T) {
 
 	// Chip - verify noop chip client is initialized and functional
 	assert.NotNil(t, noopClient.Chip)
-	var _ chipingress.Client = noopClient.Chip
 	assert.IsType(t, &chipingress.NoopClient{}, noopClient.Chip)
 
 	// Test Chip methods return no errors

pkg/billing/workflow_client.go

@@ -43,7 +43,6 @@ type workflowClient struct {
 }
 
 type workflowConfig struct {
-	log                  logger.Logger
 	transportCredentials credentials.TransportCredentials
 	tlsCert              string
 	serverName           string

pkg/capabilities/cli/cmd/generate_types.go

@@ -179,7 +179,7 @@ func ConfigFromSchemas(schemaFilePaths []string) (ConfigInfo, error) {
 			SchemaOutputFile: outputName,
 		}
 
-		configInfo.Config.SchemaMappings = append(configInfo.Config.SchemaMappings, generator.SchemaMapping{
+		configInfo.SchemaMappings = append(configInfo.SchemaMappings, generator.SchemaMapping{
 			SchemaID:    jsonSchema.ID,
 			PackageName: path.Dir(jsonSchema.ID[8:]),
 			RootType:    rootType,

pkg/capabilities/cli/cmd/go_reader.go

@@ -136,9 +136,7 @@ func (g *GoStructReader) gatherImports(node *ast.File, structs map[string]Struct
 		}
 	}
 
-	var allValues []string
 	var imports []string
-	var check []bool
 	for _, imp := range node.Imports {
 		var importName string
 		if imp.Name != nil {
@@ -149,8 +147,6 @@ func (g *GoStructReader) gatherImports(node *ast.File, structs map[string]Struct
 		}
 		importName = strings.Trim(importName, "\"")
 
-		allValues = append(allValues, importName)
-		check = append(check, requiredImports[importName])
 		if requiredImports[importName] {
 			imports = append(imports, imp.Path.Value)
 		}

pkg/capabilities/consensus/ocr3/batching_test.go

@@ -180,7 +180,8 @@ func TestQueryBatchHasCapacity(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			// Handle special edge case tests that need dynamic size calculation
 			sizeLimit := tt.sizeLimit
-			if tt.name == "exactly at limit boundary" {
+			switch tt.name {
+			case "exactly at limit boundary":
 				// Calculate exact size needed for the new ID
 				newIdSize := calculateIdSize(tt.newId)
 				if newIdSize > 0 {
@@ -190,7 +191,7 @@ func TestQueryBatchHasCapacity(t *testing.T) {
 				} else {
 					sizeLimit = 0
 				}
-			} else if tt.name == "one byte over limit" {
+			case "one byte over limit":
 				// Calculate exact size needed for the new ID minus 1
 				newIdSize := calculateIdSize(tt.newId)
 				if newIdSize > 0 {
@@ -1334,14 +1335,15 @@ func TestReportBatchHasCapacity(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			// Handle special edge case tests that need dynamic size calculation
 			sizeLimit := tt.sizeLimit
-			if tt.name == "exactly at limit boundary" {
+			switch tt.name {
+			case "exactly at limit boundary":
 				// Calculate exact size needed for the new report
 				newReportSize := calculateReportSize(tt.newReport)
 				// Always include tag and length overhead, even for empty messages
 				tagSize := varintSize(uint64(2<<3 | 2))
 				lengthSize := varintSize(uint64(newReportSize))
 				sizeLimit = tagSize + lengthSize + newReportSize
-			} else if tt.name == "one byte over limit" {
+			case "one byte over limit":
 				// Calculate exact size needed for the new report minus 1
 				newReportSize := calculateReportSize(tt.newReport)
 				// Always include tag and length overhead, even for empty messages

pkg/chainreader/contract_reader_test.go

@@ -141,9 +141,10 @@ func TestContractReaderByIDsQueryKey(t *testing.T) {
 
 	// Mock QueryKey function
 	mockReader.queryKeyFunc = func(ctx context.Context, contract types.BoundContract, filter query.KeyFilter, limitAndSort query.LimitAndSort, sequenceDataType any) ([]types.Sequence, error) {
-		if contract == bc1 {
+		switch contract {
+		case bc1:
 			return []types.Sequence{{Data: "sequenceData1"}}, nil
-		} else if contract == bc2 {
+		case bc2:
 			return []types.Sequence{{Data: "sequenceData2"}}, nil
 		}
 		return nil, fmt.Errorf("not found")