pkg/settings/limits: fix updates for global resources (#1922)

Author: jmank88

.mockery.yaml

@@ -57,3 +57,10 @@ packages:
       JWTGenerator:
       JWTAuthenticator:
       NodeAuthProvider:
+  github.com/smartcontractkit/chainlink-common/pkg/settings:
+    config:
+      filename: "mock_{{.InterfaceName | snakecase}}_test.go"
+      dir: "{{.InterfaceDir}}/limits"
+      outpkg: limits
+    interfaces:
+      Getter:

pkg/settings/limits/factory.go

@@ -12,7 +12,7 @@ import (
 
 // Factory holds optional configuration for constructing [Limit]s.
 type Factory struct {
-	// Settings is a source of dynamic limit and burst updates.
+	// Settings is a source of dynamic limit updates.
 	// [settings.Getter.GetScoped] will be polled for updates, unless Settings is also a settings.Registry, in which case
 	// the channel based [settings.Registry.SubscribeScoped] will be used instead.
 	Settings settings.Getter // optional

pkg/settings/limits/mock_getter_test.go

@@ -62,7 +62,7 @@ func newGlobalResourcePoolLimiter[N Number](f Factory, limit settings.Setting[N]
 	}
 
 	if f.Settings != nil {
-		l.getLimitFn = func(ctx context.Context) (N, error) {
+		l.resourcePoolUsage.getLimitFn = func(ctx context.Context) (N, error) {
 			return limit.GetOrDefault(ctx, f.Settings)
 		}
 		if registry, ok := f.Settings.(settings.Registry); ok {

pkg/settings/limits/resource.go

@@ -10,10 +10,12 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
 	"go.opentelemetry.io/otel/attribute"
 	"go.opentelemetry.io/otel/sdk/metric/metricdata"
 
+	"github.com/smartcontractkit/chainlink-common/pkg/config"
 	"github.com/smartcontractkit/chainlink-common/pkg/contexts"
 	"github.com/smartcontractkit/chainlink-common/pkg/settings"
 )
@@ -125,6 +127,31 @@ func ExampleMultiResourcePoolLimiter() {
 	// <nil>
 }
 
+func TestMakeResourcePoolLimiter_Update(t *testing.T) {
+	t.Parallel()
+	ctx := t.Context()
+	getter := NewGetter(t)
+	getter.On("GetScoped", mock.Anything, settings.ScopeGlobal, "foo").Return("10", nil).Twice()
+	f := Factory{Settings: getter}
+	s := settings.Size(1)
+	s.Key = "foo"
+	rl, err := MakeResourcePoolLimiter(f, s)
+	require.NoError(t, err)
+
+	// validate
+	a, err := rl.Available(ctx)
+	require.NoError(t, err)
+	assert.Equal(t, config.Size(10), a)
+	assert.Error(t, rl.Use(ctx, 11))
+	// update
+	getter.On("GetScoped", mock.Anything, settings.ScopeGlobal, "foo").Return("20", nil).Twice()
+	// re-validate
+	a, err = rl.Available(ctx)
+	require.NoError(t, err)
+	assert.Equal(t, config.Size(20), a)
+	assert.NoError(t, rl.Use(ctx, 11))
+}
+
 func TestMakeResourcePoolLimiter(t *testing.T) {
 	t.Parallel()
 	for _, tt := range []struct {