Skip to content

Commit 8f688ad

Browse files
committed
Changes from review
1 parent c9695d0 commit 8f688ad

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

pkg/workflows/wasm/host/execution_await_order_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ func TestAwaitCapabilities_headOfLineBlocksOnEarlierID(t *testing.T) {
6969
exec := &execution[*sdkpb.ExecutionResult]{
7070
ctx: t.Context(),
7171
capabilityResponses: make(map[int32]<-chan *sdkpb.CapabilityResponse),
72-
pendingCallsSem: make(chan struct{}, 100),
72+
pendingCallsSem: make(chan struct{}, defaultMaxPendingCalls),
7373
executor: stub,
7474
}
7575

pkg/workflows/wasm/host/module.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ var (
4242
defaultMinMemoryMBs = uint64(128)
4343
DefaultInitialFuel = uint64(100_000_000)
4444
defaultMaxFetchRequests = 5
45-
defaultMaxPendingCalls = 30 // matches engine CapabilityConcurrencyLimit default
45+
defaultMaxPendingCalls = 30 // matches engine CapabilityConcurrencyLimit default
4646
defaultMaxCompressedBinarySize = 20 * 1024 * 1024 // 20 MB
4747
defaultMaxDecompressedBinarySize = 100 * 1024 * 1024 // 100 MB
4848
defaultMaxResponseSizeBytes = 5 * 1024 * 1024 // 5 MB

pkg/workflows/wasm/host/module_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,7 @@ func Test_CallAwaitRace(t *testing.T) {
633633
exec := &execution[*wasmpb.ExecutionResult]{
634634
module: m,
635635
capabilityResponses: map[int32]<-chan *sdkpb.CapabilityResponse{},
636-
pendingCallsSem: make(chan struct{}, 100),
636+
pendingCallsSem: make(chan struct{}, defaultMaxPendingCalls),
637637
ctx: t.Context(),
638638
executor: mockExecHelper,
639639
}

0 commit comments

Comments
 (0)