augment OutboundHTTPResponse with helpful fields for metrics (#1519)

* add IsExternalEndpointError and ExternalEndpointLatency to OutboundHTTPResponse

* add cache settings to cresettings

Author: jinhoonbang

pkg/settings/cresettings/settings.go

@@ -66,7 +66,6 @@ var Default = Schema{
 		ConsensusCallsLimit:           Int(2),
 		LogLineLimit:                  Size(config.KByte),
 		LogEventLimit:                 Int(1_000),
-
 		CRONTrigger: cronTrigger{
 			RateLimit: Rate(rate.Every(30*time.Second), 1),
 		},

pkg/types/gateway/action.go

@@ -5,6 +5,7 @@ import (
 	"encoding/hex"
 	"sort"
 	"strconv"
+	"time"
 )
 
 const (
@@ -65,8 +66,10 @@ func (req OutboundHTTPRequest) Hash() string {
 
 // OutboundHTTPResponse represents the response from gateway to workflow node.
 type OutboundHTTPResponse struct {
-	ErrorMessage string            `json:"errorMessage,omitempty"` // error message in case of execution errors. i.e. errors before or after attempting HTTP call to external client
-	StatusCode   int               `json:"statusCode,omitempty"`   // HTTP status code
-	Headers      map[string]string `json:"headers,omitempty"`      // HTTP headers
-	Body         []byte            `json:"body,omitempty"`         // HTTP response body
+	ErrorMessage            string            `json:"errorMessage,omitempty"`            // error message for all errors except HTTP errors returned by external endpoints
+	IsExternalEndpointError bool              `json:"isExternalEndpointError,omitempty"` // indicates whether the error is from a faulty external endpoint (e.g. timeout, response size) vs error introduced internally by gateway execution
+	StatusCode              int               `json:"statusCode,omitempty"`              // HTTP status code
+	Headers                 map[string]string `json:"headers,omitempty"`                 // HTTP headers
+	Body                    []byte            `json:"body,omitempty"`                    // HTTP response body
+	ExternalEndpointLatency time.Duration     `json:"externalEndpointLatency,omitempty"` // Latency of the external endpoint
 }