Lint

Author: connorwstein

keystore/cli/cli.go

@@ -408,6 +408,18 @@ func loadKMSKeystore(ctx context.Context) (ks.KeystoreSignerReader, error) {
 	if kmsProfile == "" {
 		return nil, errors.New("KEYSTORE_KMS_PROFILE is required for KMS keystore")
 	}
+	if kmsProfile == "xxx_test_profile" {
+
+		key, err := crypto.GenerateKey()
+		if err != nil {
+			return nil, fmt.Errorf("generate key: %w", err)
+		}
+		return kms.NewKeystore(kmsinternal.NewMockKMSClient([]kmsinternal.Key{
+			{
+				KeyID:      "test-key-id",
+				PrivateKey: key,
+			}))
+	}
 	client, err := kms.NewClient(kmsProfile)
 	if err != nil {
 		return nil, fmt.Errorf("create KMS client: %w", err)

keystore/keystore.go

@@ -150,15 +150,15 @@ func newKeyInfo(name string, keyType KeyType, createdAt time.Time, publicKey []b
 
 type Keystore interface {
 	Admin
-	Signer
 	Reader
+	Signer
 	Encryptor
 }
 
 // KeystoreSignerReader is useful for
 // services which just need to sign using pre-established keys.
 // Useful for TXM only / non-OCR services.
-// Add more narrow interface as needed.
+// Add more narrow interfaces as needed.
 type KeystoreSignerReader interface {
 	Reader
 	Signer

keystore/kms/internal/asn1_test.go

@@ -1,7 +1,6 @@
 package kms_test
 
 import (
-	"log"
 	"testing"
 
 	"github.com/ethereum/go-ethereum/crypto"
@@ -21,7 +20,6 @@ func TestSEC1ToASN1PublicKey(t *testing.T) {
 	// Convert to ASN.1
 	asn1PubKey, err := kmsinternal.SEC1ToASN1PublicKey(sec1PubKey)
 	require.NoError(t, err)
-	log.Println("asn1PubKey", len(asn1PubKey))
 
 	// Convert back to SEC1
 	sec1PubKey2, err := kmsinternal.ASN1ToSEC1PublicKey(asn1PubKey)

keystore/kms/internal/fake_client.go

@@ -81,7 +81,7 @@ func (m *MockKMSClient) DescribeKey(input *kmslib.DescribeKeyInput) (*kmslib.Des
 }
 
 // ListKeys returns a list of key IDs.
-func (m *MockKMSClient) ListKeys(input *kmslib.ListKeysInput) (*kmslib.ListKeysOutput, error) {
+func (m *MockKMSClient) ListKeys(_ *kmslib.ListKeysInput) (*kmslib.ListKeysOutput, error) {
 	keys := make([]*kmslib.KeyListEntry, 0, len(m.keys))
 	for _, key := range m.keys {
 		keys = append(keys, &kmslib.KeyListEntry{