release in awaitCapabilites instead of callCapAsync

justinkaseman · justinkaseman · commit b932fc673c0a · 2026-05-19T18:11:11.000-07:00
diff --git a/pkg/workflows/wasm/host/execution.go b/pkg/workflows/wasm/host/execution.go
@@ -52,8 +52,6 @@ func (e *execution[T]) callCapAsync(ctx context.Context, req *sdkpb.CapabilityRe
 	e.capabilityResponses[req.CallbackId] = ch
 
 	go func() {
-		defer func() { <-e.pendingCallsSem }()
-
 		resp, err := e.executor.CallCapability(ctx, req)
 
 		if err != nil {
@@ -92,6 +90,7 @@ func (e *execution[T]) awaitCapabilities(ctx context.Context, acr *sdkpb.AwaitCa
 		}
 
 		delete(e.capabilityResponses, callId)
+		<-e.pendingCallsSem
 	}
 
 	return &sdkpb.AwaitCapabilitiesResponse{
@@ -118,8 +117,6 @@ func (e *execution[T]) getSecretsAsync(ctx context.Context, req *sdkpb.GetSecret
 	e.secretsResponses[req.CallbackId] = ch
 
 	go func() {
-		defer func() { <-e.pendingCallsSem }()
-
 		resp, err := e.executor.GetSecrets(ctx, req)
 		sr := &secretsResponse{responses: resp, err: err}
 
@@ -155,6 +152,7 @@ func (e *execution[T]) awaitSecrets(ctx context.Context, acr *sdkpb.AwaitSecrets
 		}
 
 		delete(e.secretsResponses, callId)
+		<-e.pendingCallsSem
 	}
 
 	return &sdkpb.AwaitSecretsResponse{

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,6 @@ func (e execution[T]) callCapAsync(ctx context.Context, req sdkpb.CapabilityRe`
`52`	`52`	`e.capabilityResponses[req.CallbackId] = ch`
`53`	`53`
`54`	`54`	`go func() {`
`55`		`- defer func() { <-e.pendingCallsSem }()`
`56`		`-`
`57`	`55`	`resp, err := e.executor.CallCapability(ctx, req)`
`58`	`56`
`59`	`57`	`if err != nil {`
`@@ -92,6 +90,7 @@ func (e execution[T]) awaitCapabilities(ctx context.Context, acr sdkpb.AwaitCa`
`92`	`90`	`}`
`93`	`91`
`94`	`92`	`delete(e.capabilityResponses, callId)`
	`93`	`+ <-e.pendingCallsSem`
`95`	`94`	`}`
`96`	`95`
`97`	`96`	`return &sdkpb.AwaitCapabilitiesResponse{`
`@@ -118,8 +117,6 @@ func (e execution[T]) getSecretsAsync(ctx context.Context, req sdkpb.GetSecret`
`118`	`117`	`e.secretsResponses[req.CallbackId] = ch`
`119`	`118`
`120`	`119`	`go func() {`
`121`		`- defer func() { <-e.pendingCallsSem }()`
`122`		`-`
`123`	`120`	`resp, err := e.executor.GetSecrets(ctx, req)`
`124`	`121`	`sr := &secretsResponse{responses: resp, err: err}`
`125`	`122`
`@@ -155,6 +152,7 @@ func (e execution[T]) awaitSecrets(ctx context.Context, acr sdkpb.AwaitSecrets`
`155`	`152`	`}`
`156`	`153`
`157`	`154`	`delete(e.secretsResponses, callId)`
	`155`	`+ <-e.pendingCallsSem`
`158`	`156`	`}`
`159`	`157`
`160`	`158`	`return &sdkpb.AwaitSecretsResponse{`