feat(beholder): add logger field to otel (#1987)

Author: kirqz23

pkg/logger/otelzap/otelzap.go

@@ -110,6 +110,11 @@ func (o OtelZapCore) Write(entry zapcore.Entry, fields []zapcore.Field) error {
 		attributes = append(attributes, attribute.String("caller", entry.Caller.String()))
 	}
 
+	// Add zap logger name when present
+	if entry.LoggerName != "" {
+		attributes = append(attributes, attribute.String("logger", entry.LoggerName))
+	}
+
 	// Add exception metadata for error levels
 	if entry.Level > zapcore.InfoLevel {
 		if entry.Stack != "" {

pkg/logger/otelzap/otelzap_test.go

@@ -189,12 +189,13 @@ func TestOtelZapCore_Write(t *testing.T) {
 	core := NewCore(logger).(*OtelZapCore)
 
 	tests := []struct {
-		name        string
-		entry       zapcore.Entry
-		fields      []zapcore.Field
-		coreFields  []zapcore.Field
-		wantMessage string
-		wantAttrs   map[string]string
+		name          string
+		entry         zapcore.Entry
+		fields        []zapcore.Field
+		coreFields    []zapcore.Field
+		wantMessage   string
+		wantAttrs     map[string]string
+		mustLackAttrs []string
 	}{
 		{
 			name: "basic info log",
@@ -206,8 +207,9 @@ func TestOtelZapCore_Write(t *testing.T) {
 			fields: []zapcore.Field{
 				{Key: "foo", Type: zapcore.StringType, String: "bar"},
 			},
-			wantMessage: "hello world",
-			wantAttrs:   map[string]string{"foo": "bar"},
+			wantMessage:   "hello world",
+			wantAttrs:     map[string]string{"foo": "bar"},
+			mustLackAttrs: []string{"logger"},
 		},
 		{
 			name: "error log with stack and caller",
@@ -227,6 +229,7 @@ func TestOtelZapCore_Write(t *testing.T) {
 				"caller":               "file.go:42",
 				"exception.stacktrace": "stacktrace",
 			},
+			mustLackAttrs: []string{"logger"},
 		},
 		{
 			name: "core fields and span context",
@@ -252,6 +255,18 @@ func TestOtelZapCore_Write(t *testing.T) {
 				"span_id":     "0405060000000000",
 				"trace_flags": "01",
 			},
+			mustLackAttrs: []string{"logger"},
+		},
+		{
+			name: "logger name is emitted",
+			entry: zapcore.Entry{
+				Message:    "named",
+				Level:      zapcore.InfoLevel,
+				Time:       time.Now(),
+				LoggerName: "svc.sub",
+			},
+			wantMessage: "named",
+			wantAttrs:   map[string]string{"logger": "svc.sub"},
 		},
 	}
 
@@ -292,6 +307,9 @@ func TestOtelZapCore_Write(t *testing.T) {
 				assert.Contains(t, got, k, "expected key %q", k)
 				assert.Equal(t, v, got[k], "mismatch for key %q", k)
 			}
+			for _, k := range tt.mustLackAttrs {
+				assert.NotContains(t, got, k, "unexpected attribute %q", k)
+			}
 		})
 	}
 }