OEV-373 Add securemint plugin type and securemint aggregator#1224
Merged
george-dorin merged 25 commits intomainfrom Jul 8, 2025
Merged
OEV-373 Add securemint plugin type and securemint aggregator#1224george-dorin merged 25 commits intomainfrom
george-dorin merged 25 commits intomainfrom
Conversation
cll-gg
force-pushed
the
OEV-373-add-secure-mint-plugin-type
branch
from
fc64563 to
f621677
Compare
cll-gg
force-pushed
the
OEV-373-add-secure-mint-plugin-type
branch
from
f621677 to
d23a649
Compare
cll-gg
force-pushed
the
OEV-373-add-secure-mint-plugin-type
branch
from
d23a649 to
c2faef9
Compare
cll-gg
force-pushed
the
OEV-373-add-secure-mint-plugin-type
branch
from
c2faef9 to
fabbdac
Compare
cll-gg
force-pushed
the
OEV-373-add-secure-mint-plugin-type
branch
from
fabbdac to
162575a
Compare
Contributor
Author
|
The two failing jobs seem to be a known issue: they also fail on this recently-merged PR #1282 |
mxiao-cll
reviewed
Jul 7, 2025
| lggr.Debugw("createOutcome called", "report", report) | ||
|
|
||
| // Convert chain selector to bytes for data ID | ||
| // Secure Mint dataID: 0x04 + chain selector as bytes + right padded with 0s |
There was a problem hiding this comment.
I don't think this is right, we won't be able to support a 2nd customer
Contributor
Author
There was a problem hiding this comment.
Good point! Shall we put the token in there as well?
There was a problem hiding this comment.
I think chain + token should be able to guarantee uniqueness, however, what's the token length limit?
Contributor
Author
There was a problem hiding this comment.
Started a discussion about this, I propose we leave it as-is for now to get the end-to-end flow working
mxiao-cll
reviewed
Jul 7, 2025
mxiao-cll
reviewed
Jul 7, 2025
agparadiso
approved these changes
Jul 8, 2025
5 tasks
george-dorin
approved these changes
Jul 8, 2025
george-dorin
had a problem deploying
to
integration
GitHub Actions
Failure
george-dorin
had a problem deploying
to
integration
GitHub Actions
Failure
george-dorin
had a problem deploying
to
integration
GitHub Actions
Failure
cll-gg
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 11, 2025
cll-gg
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 11, 2025
cll-gg
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DF-21404
Introduce securemint aggregator to be used in securemint workflows.
Supports
smartcontractkit/chainlink#18442, see specifically the
securemint_workflow_test(link)