Merged
Conversation
dhaidashenko
had a problem deploying
to
integration
GitHub Actions
Failure
dhaidashenko
had a problem deploying
to
integration
GitHub Actions
Failure
dhaidashenko
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
force-pushed
the
feature/PLEX-1577-fix-proto-helpers
branch
2 times, most recently
from
b375a9a to
98b6c24
Compare
apidiff results - backwards-incompatible changes detected ❌Module:
|
| Element | Change |
|---|---|
./pkg/capabilities/v2/chain-capabilities/evm.ConvertAddressesFromProto |
removed |
./pkg/capabilities/v2/chain-capabilities/evm.ConvertFilterToProto |
changed from func(github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.FilterQuery) *FilterQuery to func(github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.FilterQuery) (*FilterQuery, error) |
./pkg/capabilities/v2/chain-capabilities/evm.ConvertHashesFromProto |
removed |
./pkg/capabilities/v2/chain-capabilities/evm.ConvertHashFromProto |
removed |
./pkg/capabilities/v2/chain-capabilities/evm.ConvertHeaderToProto |
changed from func(github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Header) *Header to func(*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Header) (*Header, error) |
./pkg/capabilities/v2/chain-capabilities/evm.ConvertHeadFromProto |
removed |
./pkg/capabilities/v2/chain-capabilities/evm.ConvertLogsFromProto |
changed from func([]*Log) []*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log to func([]*Log) ([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log, error) |
./pkg/capabilities/v2/chain-capabilities/evm.ConvertLogsToProto |
changed from func([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log) []*Log to func([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log) ([]*Log, error) |
./pkg/capabilities/v2/chain-capabilities/evm.ConvertLogToProto |
changed from func(*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log) *Log to func(github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log) *Log |
./pkg/capabilities/v2/chain-capabilities/evm.ConvertTopicsFromProto |
changed from func([]*Topics) [][]github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Hash to func([]*Topics) ([][]github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Hash, error) |
./pkg/chains/evm.ConvertAddressesFromProto |
changed from func([][]byte) []github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Address to func([][]byte) ([]github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Address, error) |
./pkg/chains/evm.ConvertFilterToProto |
changed from func(github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.FilterQuery) *FilterQuery to func(github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.FilterQuery) (*FilterQuery, error) |
./pkg/chains/evm.ConvertGasConfigToProto |
changed from func(*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.GasConfig) *GasConfig to func(github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.GasConfig) (*GasConfig, error) |
./pkg/chains/evm.ConvertHashesFromProto |
changed from func([][]byte) []github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Hash to func([][]byte) ([]github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Hash, error) |
./pkg/chains/evm.ConvertHeaderFromProto |
changed from func(*Header) (*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Header, error) to func(*Header) (github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Header, error) |
./pkg/chains/evm.ConvertHeaderToProto |
changed from func(*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Header) *Header to func(*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Header) (*Header, error) |
./pkg/chains/evm.ConvertLogsFromProto |
changed from func([]*Log) []*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log to func([]*Log) ([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log, error) |
./pkg/chains/evm.ConvertLogsToProto |
changed from func([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log) []*Log to func([]*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log) ([]*Log, error) |
./pkg/chains/evm.ConvertLogToProto |
changed from func(*github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log) *Log to func(github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Log) *Log |
./pkg/chains/evm.ConvertSubmitTransactionRequestFromProto |
changed from func(*SubmitTransactionRequest) github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.SubmitTransactionRequest to func(*SubmitTransactionRequest) (github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.SubmitTransactionRequest, error) |
./pkg/chains/evm.ConvertTopicsFromProto |
changed from func([]*Topics) [][]github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Hash to func([]*Topics) ([][]github.com/smartcontractkit/chainlink-common/pkg/types/chains/evm.Hash, error) |
(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17214677950/#summary-48835208635)
product-security-plaid-test
Bot
requested review from
DylanTinianov,
Unheilbar,
cedric-cordenier and
patrickhuie19
and removed request for
patrickhuie19
dhaidashenko
commented
Aug 25, 2025
ilija42
force-pushed
the
feature/PLEX-1577-fix-proto-helpers
branch
from
2a774a3 to
788ad77
Compare
ilija42
force-pushed
the
feature/PLEX-1577-fix-proto-helpers
branch
from
ffbe054 to
7b836e1
Compare
dhaidashenko
commented
Aug 25, 2025
|
|
||
| var addresses []evmtypes.Address | ||
| for i, protoAddress := range protoFilter.GetAddresses() { | ||
| address, err := ConvertOptionalAddressFromProto(protoAddress) |
Contributor
Author
There was a problem hiding this comment.
Do we need to allow empty addrs here?
Contributor
There was a problem hiding this comment.
There are use cases for tracking just an event signature, we would need to setup some limits for CRE use though, but right now this is only used internally
ilija42
force-pushed
the
feature/PLEX-1577-fix-proto-helpers
branch
from
92175f3 to
99b2ab1
Compare
ilija42
approved these changes
Aug 26, 2025
jmank88
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followups: