pkg/services/otelhealth: add otelhealth; update promhealth#1494
Merged
pkg/services/otelhealth: add otelhealth; update promhealth#1494
Conversation
jmank88
commented
Aug 20, 2025
Contributor
Author
There was a problem hiding this comment.
The attributes are aligned with prom for familiarity, but perhaps they should be tweaked for otel standards? cc @pkcll
yashnevatia
reviewed
Aug 21, 2025
apidiff results - backwards-incompatible changes detected ❌Module:
|
| Element | Change |
|---|---|
./pkg/services.HealthCheckerConfig.AddUptime |
changed from func(time.Duration) to func(context.Context, time.Duration) |
./pkg/services.HealthCheckerConfig.Delete |
changed from func(string) to func(context.Context, string) |
./pkg/services.HealthCheckerConfig.IncVersion |
changed from func(string, string) to func(context.Context, string, string) |
./pkg/services.HealthCheckerConfig.SetStatus |
changed from func(string, int) to func(context.Context, string, int) |
(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17132372470/#summary-48599736657)
george-dorin
approved these changes
Aug 21, 2025
jmank88
commented
Aug 21, 2025
| } | ||
|
|
||
| func (cfg HealthCheckerConfig) setNoopHooks() { | ||
| func (cfg *HealthCheckerConfig) setNoopHooks() { |
Contributor
Author
There was a problem hiding this comment.
This was leading to nil pointers
KodeyThomas
approved these changes
Aug 21, 2025
pkcll
reviewed
Aug 21, 2025
| @@ -196,10 +199,10 @@ func (c *HealthChecker) update() { | |||
| } | |||
|
|
|||
| // report metrics to prometheus | |||
Contributor
There was a problem hiding this comment.
// report metrics to prometheus or otel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.