loop/server: wire up ChipIngressInsecureConnection option#1495
Merged
krehermann merged 2 commits intomainfrom Aug 21, 2025
Merged
loop/server: wire up ChipIngressInsecureConnection option#1495krehermann merged 2 commits intomainfrom
krehermann merged 2 commits intomainfrom
Conversation
apidiff results - no incompatible changes detected ✅Module:
|
jmank88
approved these changes
Aug 20, 2025
patrickhuie19
approved these changes
Aug 20, 2025
|
|
||
| envChipIngressEndpoint = "CL_CHIP_INGRESS_ENDPOINT" | ||
| envChipIngressEndpoint = "CL_CHIP_INGRESS_ENDPOINT" | ||
| envChipIngressInsecureConnection = "CL_CHIP_INGRESS_INSECURE_CONNECTION" |
Contributor
There was a problem hiding this comment.
We have a variety of config parameters like this now (TLS or local mode), and I think some are formatted as secure while others are formatted as insecure. insecure is probably the way to go, so no action here.
krehermann
suggested changes
Aug 20, 2025
Contributor
Author
@krehermann, pease see the note in the PR description "Companion PR smartcontractkit/chainlink#18947" |
krehermann
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loop/server: wire up ChipIngressInsecureConnection option
Why?
ChipIngress should use TLS by default, while Beholder does not use TLS for local connection to sidecar collector by default.
Related PR #1374 cc @krehermann @Tofel
Testing
Companion PR smartcontractkit/chainlink#18947
Was tested on staging on cl-keystone-one