Update relayer ccip provider interface to use dedicated args#1497
Merged
Update relayer ccip provider interface to use dedicated args#1497
Conversation
apidiff results - backwards-incompatible changes detected ❌Module:
|
| Element | Change |
|---|---|
./pkg/loop.(*RelayerService).NewCCIPProvider |
changed from func(context.Context, github.com/smartcontractkit/chainlink-common/pkg/types.RelayArgs) (github.com/smartcontractkit/chainlink-common/pkg/types.CCIPProvider, error) to func(context.Context, github.com/smartcontractkit/chainlink-common/pkg/types.CCIPProviderArgs) (github.com/smartcontractkit/chainlink-common/pkg/types.CCIPProvider, error) |
./pkg/loop/mocks.(*Relayer_NewCCIPProvider_Call).Run |
changed from func(func(_a0 context.Context, _a1 github.com/smartcontractkit/chainlink-common/pkg/types.RelayArgs)) *Relayer_NewCCIPProvider_Call to func(func(_a0 context.Context, _a1 github.com/smartcontractkit/chainlink-common/pkg/types.CCIPProviderArgs)) *Relayer_NewCCIPProvider_Call |
./pkg/loop/mocks.(*Relayer_NewCCIPProvider_Call).RunAndReturn |
changed from func(func(context.Context, github.com/smartcontractkit/chainlink-common/pkg/types.RelayArgs) (github.com/smartcontractkit/chainlink-common/pkg/types.CCIPProvider, error)) *Relayer_NewCCIPProvider_Call to func(func(context.Context, github.com/smartcontractkit/chainlink-common/pkg/types.CCIPProviderArgs) (github.com/smartcontractkit/chainlink-common/pkg/types.CCIPProvider, error)) *Relayer_NewCCIPProvider_Call |
./pkg/loop/mocks.(*Relayer).NewCCIPProvider |
changed from func(context.Context, github.com/smartcontractkit/chainlink-common/pkg/types.RelayArgs) (github.com/smartcontractkit/chainlink-common/pkg/types.CCIPProvider, error) to func(context.Context, github.com/smartcontractkit/chainlink-common/pkg/types.CCIPProviderArgs) (github.com/smartcontractkit/chainlink-common/pkg/types.CCIPProvider, error) |
./pkg/types.(*UnimplementedRelayer).NewCCIPProvider |
changed from func(context.Context, RelayArgs) (CCIPProvider, error) to func(context.Context, CCIPProviderArgs) (CCIPProvider, error) |
./pkg/types.Relayer.NewCCIPProvider |
changed from func(context.Context, RelayArgs) (CCIPProvider, error) to func(context.Context, CCIPProviderArgs) (CCIPProvider, error) |
(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17418440861/#summary-49451847127)
dhaidashenko
approved these changes
Aug 29, 2025
archseer
approved these changes
Aug 29, 2025
ogtownsend
approved these changes
Aug 29, 2025
75474ab to
130eb52
Compare
Contributor
jmank88
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added dedicated args specifically for the NewCCIPProvider method in the Relayer to support initializing the default provider in the Relayer. The generic relayer args were not providing the contract reader and chain reader config to initialize both for the default chain accessor.