Skip to content

[PRIV-128] Split Metadata and Base registry interfaces #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cedric-cordenier merged 1 commit into from
Aug 21, 2025
Merged

[PRIV-128] Split Metadata and Base registry interfaces #1500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions pkg/types/core/capabilities_registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,17 @@ import (
)

type CapabilitiesRegistry interface {
CapabilitiesRegistryBase
CapabilitiesRegistryMetadata
}

type CapabilitiesRegistryMetadata interface {
LocalNode(ctx context.Context) (capabilities.Node, error)
NodeByPeerID(ctx context.Context, peerID types.PeerID) (capabilities.Node, error)
ConfigForCapability(ctx context.Context, capabilityID string, donID uint32) (capabilities.CapabilityConfiguration, error)
CapabilitiesRegistryBase
}


type CapabilitiesRegistryBase interface {
GetTrigger(ctx context.Context, ID string) (capabilities.TriggerCapability, error)
Get(ctx context.Context, ID string) (capabilities.BaseCapability, error)
Expand All @@ -29,18 +34,21 @@ var _ CapabilitiesRegistry = UnimplementedCapabilitiesRegistry{}
var _ CapabilitiesRegistryBase = UnimplementedCapabilitiesRegistryBase{}

type UnimplementedCapabilitiesRegistry struct {
UnimplementedCapabilitiesRegistryMetadata
UnimplementedCapabilitiesRegistryBase
}

func (UnimplementedCapabilitiesRegistry) LocalNode(ctx context.Context) (capabilities.Node, error) {
type UnimplementedCapabilitiesRegistryMetadata struct {}

func (UnimplementedCapabilitiesRegistryMetadata) LocalNode(ctx context.Context) (capabilities.Node, error) {
return capabilities.Node{}, errors.New("LocalNode not implemented")
}

func (UnimplementedCapabilitiesRegistry) NodeByPeerID(ctx context.Context, peerID types.PeerID) (capabilities.Node, error) {
func (UnimplementedCapabilitiesRegistryMetadata) NodeByPeerID(ctx context.Context, peerID types.PeerID) (capabilities.Node, error) {
return capabilities.Node{}, errors.New("NodeByPeerID not implemented")
}

func (UnimplementedCapabilitiesRegistry) ConfigForCapability(ctx context.Context, capabilityID string, donID uint32) (capabilities.CapabilityConfiguration, error) {
func (UnimplementedCapabilitiesRegistryMetadata) ConfigForCapability(ctx context.Context, capabilityID string, donID uint32) (capabilities.CapabilityConfiguration, error) {
return capabilities.CapabilityConfiguration{}, errors.New("ConfigForCapability not implemented")
}

Expand Down
Loading