Skip to content

DF-21546 Configure secure mint aggregator with data id#1506

Merged
jmank88 merged 7 commits intomainfrom
DF-21546-configure-secure-mint-aggregator-with-data-id-2
Aug 27, 2025
Merged

DF-21546 Configure secure mint aggregator with data id#1506
jmank88 merged 7 commits intomainfrom
DF-21546-configure-secure-mint-aggregator-with-data-id-2

Conversation

@cll-gg
Copy link
Copy Markdown
Contributor

@cll-gg cll-gg commented Aug 26, 2025 •
edited
Loading

So far, the data id that's used for writing the secure mint report to the DF Cache contract was constructed from the chain selector. However, to enable multiple secure mint reports on the same chain, we should use a more configurable data id.
That's why in this PR the data id is set on the aggregator config in the workflow.

Supports

smartcontractkit/chainlink#19106

@cll-gg cll-gg mentioned this pull request Aug 26, 2025
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 26, 2025 •
edited
Loading

apidiff results - backwards-incompatible changes detected ❌

Module: github-com-smartcontractkit-chainlink-common

Status: ❌ 10 incompatible, 1 compatible

Incompatible Changes (10)

Element Change
./pkg/capabilities/consensus/ocr3/datafeeds.Builder removed
./pkg/capabilities/consensus/ocr3/datafeeds.ChainReportFormatter removed
./pkg/capabilities/consensus/ocr3/datafeeds.DefaultFormatterFactory removed
./pkg/capabilities/consensus/ocr3/datafeeds.ErrNoMatchingChainSelector removed
./pkg/capabilities/consensus/ocr3/datafeeds.EVMReportFormatter removed
./pkg/capabilities/consensus/ocr3/datafeeds.FormatterFactory removed
./pkg/capabilities/consensus/ocr3/datafeeds.NewDefaultFormatterFactory removed
./pkg/capabilities/consensus/ocr3/datafeeds.NewEVMReportFormatter removed
./pkg/capabilities/consensus/ocr3/datafeeds.NewSolanaReportFormatter removed
./pkg/capabilities/consensus/ocr3/datafeeds.SolanaReportFormatter removed

(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17266821226/#summary-49000810166)

@cll-gg cll-gg mentioned this pull request Aug 26, 2025
Merged
@cll-gg cll-gg marked this pull request as ready for review August 26, 2025 16:39
@cll-gg cll-gg requested a review from a team as a code owner August 26, 2025 16:40
@cll-gg
Copy link
Copy Markdown
Contributor Author

cll-gg commented Aug 26, 2025

apidiff results - backwards-incompatible changes detected ❌

Module: github-com-smartcontractkit-chainlink-common

Status: ❌ 10 incompatible, 1 compatible

Incompatible Changes (10)

Element Change
./pkg/capabilities/consensus/ocr3/datafeeds.Builder removed
./pkg/capabilities/consensus/ocr3/datafeeds.ChainReportFormatter removed
./pkg/capabilities/consensus/ocr3/datafeeds.DefaultFormatterFactory removed
./pkg/capabilities/consensus/ocr3/datafeeds.ErrNoMatchingChainSelector removed
./pkg/capabilities/consensus/ocr3/datafeeds.EVMReportFormatter removed
./pkg/capabilities/consensus/ocr3/datafeeds.FormatterFactory removed
./pkg/capabilities/consensus/ocr3/datafeeds.NewDefaultFormatterFactory removed
./pkg/capabilities/consensus/ocr3/datafeeds.NewEVMReportFormatter removed
./pkg/capabilities/consensus/ocr3/datafeeds.NewSolanaReportFormatter removed
./pkg/capabilities/consensus/ocr3/datafeeds.SolanaReportFormatter removed
(Full summary: smartcontractkit/chainlink-common/actions/runs/17244609639#summary-48930895198)

This is intended: I've un-exported several unused structs.

@cll-gg cll-gg changed the title DF-21546 Test + implementation DF-21546 Configure secure mint aggregator with data id Aug 26, 2025
Unheilbar
Unheilbar previously approved these changes Aug 26, 2025
View reviewed changes
jmank88
jmank88 reviewed Aug 26, 2025
View reviewed changes
Comment thread pkg/capabilities/consensus/ocr3/datafeeds/securemint_aggregator.go Outdated
@cll-gg cll-gg requested review from Unheilbar and jmank88 August 27, 2025 12:34
Atrax1
Atrax1 approved these changes Aug 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Atrax1 Atrax1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmank88 jmank88 merged commit 75577eb into main Aug 27, 2025
21 of 22 checks passed
@jmank88 jmank88 deleted the DF-21546-configure-secure-mint-aggregator-with-data-id-2 branch August 27, 2025 13:01
cll-gg added a commit that referenced this pull request Sep 11, 2025
@cll-gg
Revert "DF-21546 Configure secure mint aggregator with data id (#1506)"
005c546 
This reverts commit 75577eb.
This was referenced Sep 11, 2025
Closed
Closed
cll-gg added a commit that referenced this pull request Sep 11, 2025
@cll-gg
Reapply "DF-21546 Configure secure mint aggregator with data id (#1506)"
dbef2cb 
This reverts commit 005c546.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 approved these changes

@Atrax1 Atrax1 Atrax1 approved these changes

@krehermann krehermann Awaiting requested review from krehermann

@augustbleeds augustbleeds Awaiting requested review from augustbleeds

@Unheilbar Unheilbar Awaiting requested review from Unheilbar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cll-gg @jmank88 @Atrax1 @Unheilbar