Skip to content

[PRODCRE-792] Per-method onchain config for capabilities V2#1507

Merged
bolekk merged 2 commits intomainfrom
feature/PRODCRE-792-capability-config
Sep 4, 2025
Merged

[PRODCRE-792] Per-method onchain config for capabilities V2#1507
bolekk merged 2 commits intomainfrom
feature/PRODCRE-792-capability-config

Conversation

@bolekk
Copy link
Copy Markdown
Contributor

@bolekk bolekk commented Aug 28, 2025

  1. Add per-method config - each method can be either a trigger or an executable.
  2. Include some extra fields that were previously hardcoded in Launcher.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 28, 2025

apidiff results - backwards-incompatible changes detected ❌

Module: github-com-smartcontractkit-chainlink-common

Status: ❌ 6 incompatible, 50 compatible

Incompatible Changes (6)

Element Change
./pkg/capabilities.RemoteExecutableConfig.RegistrationExpiry removed
./pkg/capabilities.RemoteExecutableConfig.RegistrationRefresh removed
./pkg/capabilities/pb.(*RemoteExecutableConfig).GetRegistrationExpiry removed
./pkg/capabilities/pb.(*RemoteExecutableConfig).GetRegistrationRefresh removed
./pkg/capabilities/pb.RemoteExecutableConfig.RegistrationExpiry removed
./pkg/capabilities/pb.RemoteExecutableConfig.RegistrationRefresh removed

(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17470297807/#summary-49616699898)

@bolekk bolekk force-pushed the feature/PRODCRE-792-capability-config branch from 902e4ab to b7b8df6 Compare August 28, 2025 20:09
@bolekk bolekk force-pushed the feature/PRODCRE-792-capability-config branch from b7b8df6 to 4afb833 Compare August 28, 2025 20:24
@bolekk bolekk force-pushed the feature/PRODCRE-792-capability-config branch from 4afb833 to 15979b6 Compare August 28, 2025 20:56
@bolekk bolekk force-pushed the feature/PRODCRE-792-capability-config branch from 15979b6 to 5e752bb Compare August 29, 2025 00:00
@bolekk bolekk force-pushed the feature/PRODCRE-792-capability-config branch from 5e752bb to 9fb02dd Compare August 29, 2025 00:06
Comment thread pkg/loop/internal/core/services/capability/capabilities_registry.go Outdated
Comment thread pkg/capabilities/pb/registry.proto
@bolekk bolekk force-pushed the feature/PRODCRE-792-capability-config branch from 9fb02dd to 59fda9e Compare September 4, 2025 01:55
@bolekk bolekk force-pushed the feature/PRODCRE-792-capability-config branch from 9019c7d to cf623d0 Compare September 4, 2025 02:29
@bolekk bolekk marked this pull request as ready for review September 4, 2025 02:53
@bolekk bolekk requested a review from a team as a code owner September 4, 2025 02:53
@bolekk bolekk requested a review from a team September 4, 2025 04:10
RemoteExecutableConfig *RemoteExecutableConfig

// v2 / "NoDAG" capabilities
CapabilityMethodConfig map[string]CapabilityMethodConfig
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a comment here saying the key has to match the exact literal value of the capability's proto file like LogTrigger (trigger), WriteReport (action/executable), GetTransactionByHash (action/executable) as the generated Go code for the actions will be consistent, but for the trigger will prepend the Register, such as RegisterLogTrigger and the method to be added to that map is LogTrigger and not RegisterLogTrigger)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the prefixes are an implementation detail and the SDK will use methods exposed to the users.

@bolekk bolekk merged commit 2674110 into main Sep 4, 2025
21 of 22 checks passed
@bolekk bolekk deleted the feature/PRODCRE-792-capability-config branch September 4, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants