Skip to content

augment OutboundHTTPResponse with helpful fields for metrics #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jinhoonbang merged 5 commits into from
Sep 4, 2025
Merged

augment OutboundHTTPResponse with helpful fields for metrics #1519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a99bbee
add IsExternalEndpointError and ExternalEndpointLatency to OutboundHT…
jinhoonbang Sep 1, 2025
a68f0e2
add cache settings to cresettings
jinhoonbang Sep 1, 2025
35b45ae
Merge branch 'main' into metrics-improvements
jinhoonbang Sep 1, 2025
67e61b1
Merge branch 'main' into metrics-improvements
jinhoonbang Sep 4, 2025
6ddfcf9
Merge branch 'main' into metrics-improvements
jinhoonbang Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/settings/cresettings/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ var Default = Schema{
ConsensusCallsLimit: Int(2),
LogLineLimit: Size(config.KByte),
LogEventLimit: Int(1_000),

CRONTrigger: cronTrigger{
RateLimit: Rate(rate.Every(30*time.Second), 1),
},
Expand Down
11 changes: 7 additions & 4 deletions pkg/types/gateway/action.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"encoding/hex"
"sort"
"strconv"
"time"
)

const (
Expand Down Expand Up @@ -65,8 +66,10 @@ func (req OutboundHTTPRequest) Hash() string {

// OutboundHTTPResponse represents the response from gateway to workflow node.
type OutboundHTTPResponse struct {
ErrorMessage string `json:"errorMessage,omitempty"` // error message in case of execution errors. i.e. errors before or after attempting HTTP call to external client
StatusCode int `json:"statusCode,omitempty"` // HTTP status code
Headers map[string]string `json:"headers,omitempty"` // HTTP headers
Body []byte `json:"body,omitempty"` // HTTP response body
ErrorMessage string `json:"errorMessage,omitempty"` // error message for all errors except HTTP errors returned by external endpoints
IsExternalEndpointError bool `json:"isExternalEndpointError,omitempty"` // indicates whether the error is from a faulty external endpoint (e.g. timeout, response size) vs error introduced internally by gateway execution
StatusCode int `json:"statusCode,omitempty"` // HTTP status code
Headers map[string]string `json:"headers,omitempty"` // HTTP headers
Body []byte `json:"body,omitempty"` // HTTP response body
ExternalEndpointLatency time.Duration `json:"externalEndpointLatency,omitempty"` // Latency of the external endpoint
Comment thread
jinhoonbang marked this conversation as resolved.
}
Loading