[CRE=804] - Add tx idempotency key to EVM Service SubmitTransaction reply#1527
Merged
[CRE=804] - Add tx idempotency key to EVM Service SubmitTransaction reply#1527
Conversation
product-security-plaid-test
Bot
requested review from
DylanTinianov and
fernandezlautaro
|
👋 ilija42, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
ilija42
changed the title
apidiff results - no incompatible changes detected ✅Module:
|
ilija42
had a problem deploying
to
integration
GitHub Actions
Failure
Unheilbar
approved these changes
Sep 7, 2025
silaslenihan
approved these changes
Sep 8, 2025
patrickhuie19
approved these changes
Sep 8, 2025
| message SubmitTransactionReply { | ||
| bytes txHash = 1; | ||
| TxStatus txStatus = 2; | ||
| string tx_idempotency_key = 3; // idempotency key generated for this transaction |
Contributor
There was a problem hiding this comment.
are txHash and tx_idempotency_key related in any way? we do that for workflowExecutionIDs, and it tends to be pretty useful in scenarios when you need to forecast an execution ID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idempotency key wasn't surfaced from SubmiTransaction which makes it impossible to retrieve some tx meta data from the evm chain capability