CCIP - re-sync chain accessor on gRPC client refresh#1531
Closed
ogtownsend wants to merge 8 commits intoogt/chain-accessor-add-price-reader-interfacesfrom
Closed
CCIP - re-sync chain accessor on gRPC client refresh#1531ogtownsend wants to merge 8 commits intoogt/chain-accessor-add-price-reader-interfacesfrom
ogtownsend wants to merge 8 commits intoogt/chain-accessor-add-price-reader-interfacesfrom
Conversation
apidiff results - no modules to analyze |
5b7d6a6 to
a050460
Compare
a050460 to
2a8ce4c
Compare
jmank88
reviewed
Sep 8, 2025
| func(ctx context.Context) error { | ||
| r.Logger.Info("CCIP Provider connection refreshed - refreshing chain accessor contracts") | ||
| if ccipProvider, ok := provider.(*ccipocr3.CCIPProviderClient); ok { | ||
| return ccipProvider.RefreshChainAccessor(ctx) |
Contributor
There was a problem hiding this comment.
I think this will actually deadlock, because this call is blocked by the lock being held up the stack.
ogtownsend
commented
Sep 8, 2025
8326424 to
2ae539c
Compare
2ae539c to
025d2b5
Compare
41d7642 to
a3ca259
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports