adding otlptracegrpc.WithCompressor(gzip),#1534
Merged
Conversation
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
apidiff results - no incompatible changes detected ✅(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17613646498/#summary-50041278945) |
dhaidashenko
reviewed
Sep 9, 2025
| traceExporter, err := otlptracegrpc.New(ctx, | ||
| otlptracegrpc.WithGRPCConn(conn), | ||
| otlptracegrpc.WithHeaders(config.AuthHeaders), | ||
| otlptracegrpc.WithCompressor("gzip"), |
Contributor
There was a problem hiding this comment.
Use gzip.Name for imported artifacts. gzip package contains init that runs only if pkg is imported. Without it compression might not work
dhaidashenko
approved these changes
Sep 10, 2025
ilija42
approved these changes
Sep 10, 2025
yashnevatia
added a commit
that referenced
this pull request
Sep 10, 2025
This reverts commit afe0f95.
cedric-cordenier
pushed a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports