Skip to content

adding otlptracegrpc.WithCompressor(gzip),#1534

Merged
ilija42 merged 4 commits intomainfrom
otlp-withCompressor
Sep 10, 2025
Merged

adding otlptracegrpc.WithCompressor(gzip),#1534
ilija42 merged 4 commits intomainfrom
otlp-withCompressor

Conversation

@yashnevatia
Copy link
Copy Markdown
Contributor

Requires

Supports

@yashnevatia yashnevatia requested a review from a team as a code owner September 9, 2025 15:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 9, 2025

👋 yashnevatia, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 9, 2025

apidiff results - no incompatible changes detected ✅

(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17613646498/#summary-50041278945)

Comment thread pkg/loop/telem.go Outdated
traceExporter, err := otlptracegrpc.New(ctx,
otlptracegrpc.WithGRPCConn(conn),
otlptracegrpc.WithHeaders(config.AuthHeaders),
otlptracegrpc.WithCompressor("gzip"),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use gzip.Name for imported artifacts. gzip package contains init that runs only if pkg is imported. Without it compression might not work

@ilija42 ilija42 merged commit afe0f95 into main Sep 10, 2025
20 of 22 checks passed
@ilija42 ilija42 deleted the otlp-withCompressor branch September 10, 2025 13:11
yashnevatia added a commit that referenced this pull request Sep 10, 2025
cedric-cordenier pushed a commit that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants