Skip to content

Fix a bug in the CRE SDK standard test verifying calls are async, it allowed the first request to respond before the second was made #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MStreet3 merged 3 commits into from
Sep 18, 2025
Merged

Fix a bug in the CRE SDK standard test verifying calls are async, it allowed the first request to respond before the second was made #1554

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33765fe
Fix a bug in the CRE SDK standard test verifying calls are async, it …
nolag Sep 17, 2025
12eddf6
Add comment
nolag Sep 17, 2025
61ba5fb
Merge branch 'main' into rtinianov_fixStdTest
nolag Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pkg/workflows/wasm/host/standard_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ func TestStandardErrors(t *testing.T) {
}

func TestStandardCapabilityCallsAreAsync(t *testing.T) {
// This test expects basic action's PerformAction to be called twice asynchronously and the results concatenated.
// To ensure the calls are actually async, the mock will block the first call until the second call is made.
// The first call sets InputThing to true, the second to false.
t.Parallel()
mockExecutionHelper := NewMockExecutionHelper(t)
mockExecutionHelper.EXPECT().GetWorkflowExecutionID().Return("id")
Expand All @@ -98,12 +101,10 @@ func TestStandardCapabilityCallsAreAsync(t *testing.T) {
require.NoError(t, err)

// Don't return until the second call has been executed
defer func() {
if !input.InputThing {
mt.Lock()
}
defer mt.Unlock()
}()
if input.InputThing {
mt.Lock()
}
defer mt.Unlock()
return &sdk.CapabilityResponse{
Response: &sdk.CapabilityResponse_Payload{Payload: payload},
}, nil
Expand Down
Loading