Merged
Conversation
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
apidiff results - backwards-incompatible changes detected ❌Module:
|
| Element | Change |
|---|---|
./pkg/types.CCIPProviderArgs.OffRampAddress |
changed from string to github.com/smartcontractkit/chainlink-common/pkg/types/ccipocr3.UnknownAddress |
./pkg/types.CCIPProviderArgs.PluginType |
changed from uint32 to github.com/smartcontractkit/chainlink-common/pkg/types/ccipocr3.PluginType |
(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17987758849/#summary-51170136424)
ogtownsend
reviewed
Sep 24, 2025
| // pluginType is actually a uint8 but uint32 is the smallest supported by protobuf | ||
| uint32 pluginType = 5; | ||
| map<string, bytes> synced_addresses = 6; // map[contract_name]contract_address | ||
| string transmitter = 7; |
Contributor
There was a problem hiding this comment.
nit: could we name this TransmitterAddress or TransmitterAddrString to make it clear what it is
Contributor
Author
There was a problem hiding this comment.
Updated in the latest commit. Went with TransmitterAddress
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
requested review from
0xAustinWang,
agusaldasoro,
asoliman92,
makramkd,
mateusz-sekara,
tt-cll and
winder
product-security-plaid-test
Bot
requested review from
ilija42 and
krehermann
ogtownsend
reviewed
Sep 24, 2025
Comment on lines
+63
to
+67
| bytes offRampAddress = 4; | ||
| // pluginType is actually a uint8 but uint32 is the smallest supported by protobuf | ||
| uint32 pluginType = 5; | ||
| map<string, bytes> synced_addresses = 6; // map[contract_name]contract_address | ||
| string transmitterAddress = 7; |
Contributor
There was a problem hiding this comment.
you had mentioned bytes offRampAddress is easier to manage if it's passed in as bytes, does the same apply for transmitterAddress?
Contributor
Author
There was a problem hiding this comment.
Keeping transmitter as a string is ok since we don't have to decode it. It's just used to serve as a string out of the transmitter here
| OffRampAddress: rargs.OffRampAddress, | ||
| PluginType: rargs.PluginType, | ||
| PluginType: ccipocr3types.PluginType(rargs.PluginType), | ||
| Transmitter: rargs.Transmitter, |
| pluginType uint32 | ||
| offRampAddress ccipocr3.UnknownAddress | ||
| pluginType ccipocr3.PluginType | ||
| transmitter string |
| ExternalJobID uuid.UUID | ||
| OffRampAddress ccipocr3.UnknownAddress | ||
| PluginType ccipocr3.PluginType | ||
| TransmitterAddress string |
Contributor
There was a problem hiding this comment.
similar to above, could we make this ccipocr3.UnknownAddress for consistency, or does that introduce codec complications
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
previously approved these changes
Sep 24, 2025
amit-momin
had a problem deploying
to
integration
GitHub Actions
Error
amit-momin
had a problem deploying
to
integration
GitHub Actions
Error
amit-momin
had a problem deploying
to
integration
GitHub Actions
Error
amit-momin
force-pushed
the
feature/update-ccip-provider-args-and-types
branch
from
1405e13 to
076fb06
Compare
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
approved these changes
Sep 24, 2025
jmank88
approved these changes
Sep 24, 2025
winder
approved these changes
Sep 24, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.