Skip to content

Add CapabilityRegistry to the ClientCapability's Initialize interface#1565

Closed
nadahalli wants to merge 6 commits intomainfrom
PRIV-192
Closed

Add CapabilityRegistry to the ClientCapability's Initialize interface#1565
nadahalli wants to merge 6 commits intomainfrom
PRIV-192

Conversation

@nadahalli
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 26, 2025

apidiff results - backwards-incompatible changes detected ❌

Module: github-com-smartcontractkit-chainlink-common

Status: ❌ 12 incompatible, 0 compatible

Incompatible Changes (12)

Element Change
./pkg/capabilities/v2/actions/confidentialhttp/server.ClientCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error
./pkg/capabilities/v2/actions/http/server.ClientCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error
./pkg/capabilities/v2/chain-capabilities/evm/server.ClientCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error
./pkg/capabilities/v2/consensus/server.ConsensusCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error
./pkg/capabilities/v2/protoc/pkg/test_capabilities/actionandtrigger/server.BasicCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error
./pkg/capabilities/v2/protoc/pkg/test_capabilities/basicaction/server.BasicActionCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error
./pkg/capabilities/v2/protoc/pkg/test_capabilities/basictrigger/server.BasicCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error
./pkg/capabilities/v2/protoc/pkg/test_capabilities/consensus/server.ConsensusCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error
./pkg/capabilities/v2/protoc/pkg/test_capabilities/importclash/server.BasicActionCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error
./pkg/capabilities/v2/protoc/pkg/test_capabilities/nodeaction/server.BasicActionCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error
./pkg/capabilities/v2/triggers/cron/server.CronCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error
./pkg/capabilities/v2/triggers/http/server.HTTPCapability.Initialise changed from func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error to func(context.Context, string, github.com/smartcontractkit/chainlink-common/pkg/types/core.TelemetryService, github.com/smartcontractkit/chainlink-common/pkg/types/core.KeyValueStore, github.com/smartcontractkit/chainlink-common/pkg/types/core.CapabilitiesRegistry, github.com/smartcontractkit/chainlink-common/pkg/types/core.ErrorLog, github.com/smartcontractkit/chainlink-common/pkg/types/core.PipelineRunnerService, github.com/smartcontractkit/chainlink-common/pkg/types/core.RelayerSet, github.com/smartcontractkit/chainlink-common/pkg/types/core.OracleFactory, github.com/smartcontractkit/chainlink-common/pkg/types/core.GatewayConnector, github.com/smartcontractkit/chainlink-common/pkg/types/core.Keystore) error

(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/18313325439/#summary-52146995954)

@vreff vreff marked this pull request as ready for review October 1, 2025 17:33
@vreff vreff requested review from a team as code owners October 1, 2025 17:33
@nadahalli nadahalli requested a review from nolag October 7, 2025 13:51
@nadahalli nadahalli closed this Oct 8, 2025
@nadahalli nadahalli deleted the PRIV-192 branch October 8, 2025 10:24
@vreff vreff restored the PRIV-192 branch October 8, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants