Skip to content

INFOPLAT 2962 rotating beholder headers#1567

Merged
jmank88 merged 22 commits intomainfrom
INFOPLAT-2962-rotating-beholder-headers
Oct 7, 2025
Merged

INFOPLAT 2962 rotating beholder headers#1567
jmank88 merged 22 commits intomainfrom
INFOPLAT-2962-rotating-beholder-headers

Conversation

@hendoxc
Copy link
Copy Markdown
Contributor

@hendoxc hendoxc commented Sep 29, 2025

What

  • Adds rotating header impl
  • **beholder.Config has Signer property, which can be satisfied by passing keystore.Keystore

Why

  • beholder. uses auth headers that expire

@hendoxc hendoxc requested review from a team as code owners September 29, 2025 20:06
@github-actions
Copy link
Copy Markdown

👋 hendoxc, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 29, 2025

✅ API Diff Results - No breaking changes


📄 View full apidiff report | 📚 Learn about apidiff

@hendoxc hendoxc force-pushed the INFOPLAT-2962-rotating-beholder-headers branch from 11a3eb9 to 9ef66d9 Compare September 29, 2025 20:07
@hendoxc hendoxc force-pushed the INFOPLAT-2962-rotating-beholder-headers branch from f9cca79 to 4259f84 Compare September 29, 2025 20:21
@hendoxc hendoxc force-pushed the INFOPLAT-2962-rotating-beholder-headers branch from 4259f84 to 82ca843 Compare September 29, 2025 20:25
Adjust return type

Small refactor

Adjust test
pkcll
pkcll previously approved these changes Oct 6, 2025
pkcll
pkcll previously approved these changes Oct 7, 2025
@jmank88 jmank88 enabled auto-merge (squash) October 7, 2025 18:25
@jmank88 jmank88 merged commit 2560b72 into main Oct 7, 2025
18 of 20 checks passed
@jmank88 jmank88 deleted the INFOPLAT-2962-rotating-beholder-headers branch October 7, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants