INFOPLAT 2962 rotating beholder headers#1567
Merged
Conversation
|
👋 hendoxc, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
- fixes unhandled error
Fixes quotes
Fixes tests
11a3eb9 to
9ef66d9
Compare
f9cca79 to
4259f84
Compare
4259f84 to
82ca843
Compare
Adjust return type Small refactor Adjust test
pkcll
previously approved these changes
Oct 6, 2025
pkcll
previously approved these changes
Oct 7, 2025
pkcll
approved these changes
Oct 7, 2025
jmank88
approved these changes
Oct 7, 2025
fouadkada
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
beholder.ConfighasSignerproperty, which can be satisfied by passingkeystore.KeystoreWhy