Closed
Conversation
apidiff results - backwards-incompatible changes detected ❌Module:
|
| Element | Change |
|---|---|
./pkg/types.CCIPProviderArgs.OffRampAddress |
changed from string to github.com/smartcontractkit/chainlink-common/pkg/types/ccipocr3.UnknownAddress |
./pkg/types.CCIPProviderArgs.PluginType |
changed from uint32 to github.com/smartcontractkit/chainlink-common/pkg/types/ccipocr3.PluginType |
./pkg/types/ccipocr3.ExtraDataCodec |
removed |
./pkg/types/ccipocr3.PriceReader.GetFeeQuoterTokenUpdates |
changed from func(context.Context, []UnknownEncodedAddress, ChainSelector) (map[UnknownEncodedAddress]TimestampedUnixBig, error) to func(context.Context, []UnknownAddress) (map[UnknownEncodedAddress]TimestampedUnixBig, error) |
(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/18159633055/#summary-51687290021)
pkcll
force-pushed
the
INFOPLAT-2938-logs-streaming-loopp-heartbeat
branch
from
597278b to
c7fce9e
Compare
pkcll
force-pushed
the
INFOPLAT-2938-logs-streaming-loopp-heartbeat
branch
from
c7fce9e to
9913741
Compare
pkcll
force-pushed
the
INFOPLAT-2938-logs-streaming-loopp-heartbeat
branch
from
9913741 to
7bb83e1
Compare
…nto INFOPLAT-2938-logs-streaming-loopp
…logs-streaming-loopp-heartbeat
hendoxc
reviewed
Oct 6, 2025
Comment on lines
+84
to
+102
| func WithEmitter(emitter Emitter) HeartbeatOpt { | ||
| return func(h *Heartbeat) { | ||
| h.Emitter = emitter | ||
| } | ||
| } | ||
|
|
||
| // WithMeter sets a custom meter for the heartbeat | ||
| func WithMeter(meter metric.Meter) HeartbeatOpt { | ||
| return func(h *Heartbeat) { | ||
| h.Meter = meter | ||
| } | ||
| } | ||
|
|
||
| // WithTracer sets a custom tracer for the heartbeat | ||
| func WithTracer(tracer trace.Tracer) HeartbeatOpt { | ||
| return func(h *Heartbeat) { | ||
| h.Tracer = tracer | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
These will pollute the beholder pkg namespace. might be better to use a config struct like heartbeatConfig
pkcll
force-pushed
the
INFOPLAT-2938-logs-streaming-loopp
branch
from
0f06f1d to
c913da4
Compare
|
This PR is stale because it has been open 30 days with no activity. |
|
This PR has been automatically closed because it has been stale for > 30 days. |
github-actions
Bot
deleted the
INFOPLAT-2938-logs-streaming-loopp-heartbeat
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add beholder heartbeat
Based of #1566