Skip to content

PLEX-1767 Fix missing checks in ConvertExpressionsFromProto#1575

Merged
ilija42 merged 2 commits intomainfrom
fix/PLEX-1767-missing-checks-in-convertExpressionsFromProto
Oct 1, 2025
Merged

PLEX-1767 Fix missing checks in ConvertExpressionsFromProto#1575
ilija42 merged 2 commits intomainfrom
fix/PLEX-1767-missing-checks-in-convertExpressionsFromProto

Conversation

@dhaidashenko
Copy link
Copy Markdown
Contributor

@dhaidashenko dhaidashenko commented Oct 1, 2025

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 1, 2025

apidiff results - backwards-incompatible changes detected ❌

Module: github-com-smartcontractkit-chainlink-common

Status: ❌ 1 incompatible, 0 compatible

Incompatible Changes (1)

Element Change
./pkg/chains/evm.ConvertHashedValueComparatorsFromProto changed from func([]*HashValueComparator) []github.com/smartcontractkit/chainlink-common/pkg/types/query/primitives/evm.HashedValueComparator to func([]*HashValueComparator) ([]github.com/smartcontractkit/chainlink-common/pkg/types/query/primitives/evm.HashedValueComparator, error)

(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/18176029517/#summary-51742022573)

@dhaidashenko dhaidashenko marked this pull request as ready for review October 1, 2025 17:13
@dhaidashenko dhaidashenko requested review from a team as code owners October 1, 2025 17:13
@ilija42 ilija42 enabled auto-merge (squash) October 1, 2025 21:22
@ilija42 ilija42 merged commit 0a7ba24 into main Oct 1, 2025
18 of 20 checks passed
@ilija42 ilija42 deleted the fix/PLEX-1767-missing-checks-in-convertExpressionsFromProto branch October 1, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants